public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support
Date: Sat, 16 May 2026 13:13:42 +1000	[thread overview]
Message-ID: <review-patch2-20260512144104.761531-3-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260512144104.761531-3-prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch Review

**Status: Has issues.**

The compatible string additions and the RZ/N2H fallback to RZ/T2H look correct:

```yaml
+          - renesas,r9a09g077-du # RZ/T2H
      - items:
+          - const: renesas,r9a09g087-du # RZ/N2H
+          - const: renesas,r9a09g077-du # RZ/T2H fallback
```

**Issue 1 — `resets` removal from global `required` plus if/else pattern:**

The patch removes `resets` from the global required list:

```yaml
-  - resets
```

And then adds an if/else block to conditionally require it:

```yaml
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: renesas,r9a09g077-du
+    then:
+      properties:
+        resets: false
+    else:
+      required:
+        - resets
```

The `else` clause applies to every `allOf` entry that **doesn't** match the `if`. In a JSON Schema `allOf` list, each `if/then/else` item is evaluated independently. Since this is its own standalone item in the `allOf` array, the `else` branch should correctly require `resets` for all non-RZ/T2H compatibles. However, this pattern is unusual in DT bindings — most schemas simply list conditional requirements via `if/then` without `else`. It works, but a reviewer may ask whether it would be clearer to keep `resets` in the global `required` list and only use `if/then` to mark `resets: false` for RZ/T2H, since the `else` with `required: [resets]` is redundant with having it in the global list. Worth checking whether the dt-bindings maintainers prefer one style or the other.

**Issue 2 — port@1 constraint scope:** The patch groups `r9a09g077-du` (RZ/T2H) with `r9a07g043u-du` (RZ/G2UL) in the existing `if` block for single-port-only SoCs:

```yaml
          contains:
-            const: renesas,r9a07g043u-du
+            enum:
+              - renesas,r9a07g043u-du
+              - renesas,r9a09g077-du
```

This correctly constrains RZ/T2H to port@0 only and inherits the `port@1: false` from patch 1. This is appropriate since RZ/T2H has only a DPI output.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  3:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:40 [PATCH v3 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-05-12 14:41 ` [PATCH v3 1/5] dt-bindings: display: renesas, rzg2l-du: Refuse port@1 for RZ/G2UL Prabhakar
2026-05-14 13:20   ` [PATCH v3 1/5] dt-bindings: display: renesas,rzg2l-du: " Rob Herring (Arm)
2026-05-16  3:13   ` Claude review: dt-bindings: display: renesas, rzg2l-du: " Claude Code Review Bot
2026-05-12 14:41 ` [PATCH v3 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-14 15:23   ` [PATCH v3 2/5] dt-bindings: display: renesas,rzg2l-du: " Rob Herring (Arm)
2026-05-16  3:13   ` Claude Code Review Bot [this message]
2026-05-12 14:41 ` [PATCH v3 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-05-12 14:41 ` [PATCH v3 4/5] drm: renesas: rz-du: Move mode_valid logic to per-output clock limits Prabhakar
2026-05-13 23:02   ` Laurent Pinchart
2026-05-14 12:56     ` Lad, Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-05-12 14:41 ` [PATCH v3 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-05-16  3:13 ` Claude review: Add DU support for RZ/T2H and RZ/N2H SoCs Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-29 17:00 [PATCH 0/4] " Prabhakar
2026-04-29 17:00 ` [PATCH 1/4] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-05  1:22   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260512144104.761531-3-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox