Claude review: drm/msm: Always use component model for standalone GPU

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Verdict: The design change is sound, with a minor concern.**

This patch converts the standalone GPU path from a shortcut that bypasses the component framework into a proper component master + component setup. The GPU pdev becomes both the component master and a component of itself, preparing for the GMU to be added as a second component in patch 5.

The `msm_gpu_probe` changes look correct:

```c
+	ret = add_gpu_components(&pdev->dev, &match);
+	if (ret)
+		return ret;
+
+	return component_master_add_with_match(&pdev->dev, &msm_gpu_drm_ops,
+					       match);
```

Wait -- at this point in the series (patch 4, before patch 5), `add_gpu_components` only adds the GPU node itself via `drm_of_component_match_add`. But looking at the patched `add_gpu_components` from patch 4's diff... actually patch 4 replaces the inline `drm_of_component_match_add` with a call to `add_gpu_components`. But `add_gpu_components` at this stage (before patch 5) still only adds the GPU node. However, patch 5 modifies `add_gpu_components` to also add the GMU node. So this is fine as a building block.

The error path in `adreno_probe` is correct:

```c
+	ret = component_add(&pdev->dev, &a3xx_ops);
+	if (ret && msm_gpu_use_separate_drm_dev(pdev))
+		msm_gpu_remove(pdev);
```

The comment about "Future patches add the GMU node as a second component" is appropriate but is removed in patch 5, which is good.

---

---
Generated by Claude Code Patch Reviewer