From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Attach a driver to GMU
Date: Sat, 16 May 2026 12:47:07 +1000 [thread overview]
Message-ID: <review-overall-20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm: Attach a driver to GMU
Author: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Patches: 13
Reviewed: 2026-05-16T12:47:07.090237
---
This 5-patch series addresses `sync_state()` warnings from genpd when the GMU device node has no driver bound. The approach is to register a proper platform driver for the GMU and integrate it as a component device alongside the GPU in the DRM component model.
The series is logically structured: patches 1-3 are preparatory fixes, patch 4 restructures the standalone GPU path to always use the component framework, and patch 5 introduces the GMU driver. The overall direction is sound, but the key mechanism in patch 5 -- passing the `a6xx_gpu` pointer to the GMU bind callback via `platform_set_drvdata` on another device -- is fragile and introduces a cross-component coupling that could lead to a dangling pointer on error paths. This should be addressed before merging.
The series is marked RFT (Request For Testing) which is appropriate given the scope of changes.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-16 2:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 20:52 [PATCH RFT 0/5] drm/msm: Attach a driver to GMU Akhil P Oommen
2026-05-12 20:52 ` [PATCH RFT 1/5] drm/msm/adreno/a6xx: Mark cxpd device_link as stateless Akhil P Oommen
2026-05-13 0:56 ` Dmitry Baryshkov
2026-05-16 2:47 ` Claude review: " Claude Code Review Bot
2026-05-12 20:52 ` [PATCH RFT 2/5] drm/msm: Centralize the standalone drm device check for GPU Akhil P Oommen
2026-05-13 5:41 ` Dmitry Baryshkov
2026-05-13 21:10 ` Akhil P Oommen
2026-05-16 2:47 ` Claude review: " Claude Code Review Bot
2026-05-12 20:52 ` [PATCH RFT 3/5] drm/msm/adreno: Fix invalid drvdata typecast in adreno_remove() Akhil P Oommen
2026-05-13 5:39 ` Dmitry Baryshkov
2026-05-16 2:47 ` Claude review: " Claude Code Review Bot
2026-05-12 20:52 ` [PATCH RFT 4/5] drm/msm: Always use component model for standalone GPU Akhil P Oommen
2026-05-13 11:43 ` Dmitry Baryshkov
2026-05-13 21:09 ` Akhil P Oommen
2026-05-16 2:47 ` Claude review: " Claude Code Review Bot
2026-05-12 20:53 ` [PATCH RFT 5/5] drm/msm: Attach a driver to the GMU Akhil P Oommen
2026-05-13 11:46 ` Dmitry Baryshkov
2026-05-16 2:47 ` Claude review: " Claude Code Review Bot
2026-05-16 2:47 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox