From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/hw_error: Use HW_ERR prefix in log
Date: Thu, 04 Jun 2026 13:22:00 +1000 [thread overview]
Message-ID: <review-patch4-20260602044919.702209-5-raag.jadav@intel.com> (raw)
In-Reply-To: <20260602044919.702209-5-raag.jadav@intel.com>
Patch Review
**Verdict: Fine, minor nit.**
Adds the standard kernel `HW_ERR` (`"[Hardware Error]: "`) prefix to the `log_hw_error`, `log_gt_err`, and `log_soc_error` functions. The file already uses `HW_ERR` extensively elsewhere (e.g., lines 199, 207, 443, 475, 479 in the patched file), so this makes these functions consistent.
**Minor nit:** The `Fixes:` tag references `01aab7e1c9d4 ("drm/xe/xe_hw_error: Add support for PVC SoC errors")`. Using a Fixes tag implies stable-kernel backport eligibility, which seems heavy for a log-format consistency change. This is ultimately a maintainer judgment call — if there's tooling that relies on `HW_ERR` for parsing or alerting, the Fixes tag is justified.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 4:48 [PATCH v3 0/4] DRM RAS Fixes Raag Jadav
2026-06-02 4:48 ` [PATCH v3 1/4] drm/ras: Cancel and free message on get counter failure Raag Jadav
2026-06-04 3:22 ` Claude review: " Claude Code Review Bot
2026-06-02 4:48 ` [PATCH v3 2/4] drm/xe/drm_ras: Make counter allocation drm managed Raag Jadav
2026-06-04 3:22 ` Claude review: " Claude Code Review Bot
2026-06-02 4:48 ` [PATCH v3 3/4] drm/xe/drm_ras: Add per node cleanup action Raag Jadav
2026-06-04 3:22 ` Claude review: " Claude Code Review Bot
2026-06-02 4:48 ` [PATCH v3 4/4] drm/xe/hw_error: Use HW_ERR prefix in log Raag Jadav
2026-06-04 3:22 ` Claude Code Review Bot [this message]
2026-06-04 3:21 ` Claude review: DRM RAS Fixes Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-23 5:00 [PATCH v2 0/4] " Raag Jadav
2026-05-23 5:00 ` [PATCH v2 4/4] drm/xe/hw_error: Use HW_ERR prefix in log Raag Jadav
2026-05-25 7:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260602044919.702209-5-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox