public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: renesas: Add Renesas R-Car V4H DSC
Date: Sat, 16 May 2026 10:53:56 +1000	[thread overview]
Message-ID: <review-patch5-20260514-rcar-du-dsc-v1-5-d65f7a9e9841@ideasonboard.com> (raw)
In-Reply-To: <20260514-rcar-du-dsc-v1-5-d65f7a9e9841@ideasonboard.com>

Patch Review

**Status: Looks good.**

The DTS changes correctly wire the DSC into the pipeline between DU and DSI1:

- `du_out_dsi1` now points to `dsc_in_dsi1` (was `dsi1_in`)
- DSC port@0 input connects to DU, port@1 output connects to DSI1
- `dsi1_in` now points to `dsc_out_dsi1` (was `du_out_dsi1`)

The DSC node is `status = "disabled"` by default in the SoC dtsi, and the Sparrow Hawk board dts enables it:

```dts
&dsc {
    status = "okay";
};
```

One observation: this inserts the DSC unconditionally into the DSI1 pipeline at the SoC level. This means every board using DSI1 on this SoC must now also enable the DSC node. The cover letter confirms this matches the hardware topology (DSC is always between DU and DSI1 on V4H). The `status = "disabled"` default handles boards that don't use DSI1 at all.

The node placement and properties (clocks, power-domains, resets matching module ID 2819 from patch 1) are consistent with the binding from patch 2.

---

**Summary of required changes:**
1. **Patch 3:** Fix the bridge reference leak - use `devm_drm_of_get_bridge()` instead of `of_drm_find_and_get_bridge()`, or add explicit cleanup via `drm_bridge_put()`.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  0:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 12:24 [PATCH 0/5] drm/rcar-du: Add support for DSI pipelines with DSC Tomi Valkeinen
2026-05-14 12:24 ` [PATCH 1/5] clk: renesas: r8a779g0: Add DSC clock Tomi Valkeinen
2026-05-16  0:53   ` Claude review: " Claude Code Review Bot
2026-05-14 12:24 ` [PATCH 2/5] dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings Tomi Valkeinen
2026-05-14 13:47   ` Rob Herring (Arm)
2026-05-16  0:53   ` Claude review: " Claude Code Review Bot
2026-05-14 12:24 ` [PATCH 3/5] drm/rcar-du: dsc: Add rudimentary Renesas R-Car V4H DSC driver Tomi Valkeinen
2026-05-15  7:49   ` Geert Uytterhoeven
2026-05-15  8:02     ` Tomi Valkeinen
2026-05-15  8:05       ` Geert Uytterhoeven
2026-05-15  8:17         ` Tomi Valkeinen
2026-05-15  8:47           ` Geert Uytterhoeven
2026-05-15  9:29   ` Philipp Zabel
2026-05-16  0:53   ` Claude review: " Claude Code Review Bot
2026-05-14 12:24 ` [PATCH 4/5] drm/rcar-du: dsi: Support DSC in the pipeline Tomi Valkeinen
2026-05-16  0:53   ` Claude review: " Claude Code Review Bot
2026-05-14 12:24 ` [PATCH 5/5] arm64: dts: renesas: Add Renesas R-Car V4H DSC Tomi Valkeinen
2026-05-16  0:53   ` Claude Code Review Bot [this message]
2026-05-16  0:53 ` Claude review: drm/rcar-du: Add support for DSI pipelines with DSC Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-15  7:56 [PATCH v2 0/5] " Tomi Valkeinen
2026-05-15  7:56 ` [PATCH v2 5/5] arm64: dts: renesas: Add Renesas R-Car V4H DSC Tomi Valkeinen
2026-05-15 23:46   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260514-rcar-du-dsc-v1-5-d65f7a9e9841@ideasonboard.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox