public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH 5/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable GPU and display pipeline
Date: Mon, 25 May 2026 19:16:37 +1000	[thread overview]
Message-ID: <review-patch5-def01730-bd5d-4c61-a302-a9ca625cda7a@linaro.org> (raw)
In-Reply-To: <def01730-bd5d-4c61-a302-a9ca625cda7a@linaro.org>

Patch Review

**Issue 1 — `dp-connector` used as a bridge.** The `hdmi-bridge` node uses `compatible = "dp-connector"`:

```dts
+	hdmi-bridge {
+		compatible = "dp-connector";
+		label = "hdmi";
+		type = "full-size";
```

The `dp-connector` binding (Documentation/devicetree/bindings/display/connector/dp-connector.yaml) represents a *physical DP connector* — the port where you plug in a DP cable. The RA620 is not a DP connector; it's a DP-to-HDMI bridge. Using `dp-connector` to model a bridge is semantically incorrect.

Furthermore, the `dp-connector` binding defines port@1 as "Connection to controller providing AUX signals." This patch uses port@1 as an output to the HDMI connector, which doesn't match the binding:

```dts
+			port@1 {
+				reg = <1>;
+				hdmi_bridge_out: endpoint {
+					remote-endpoint = <&hdmi_connector_in>;
+				};
+			};
```

**Issue 2 — Naming confusion.** The node is called `hdmi-bridge` but uses `dp-connector` compatible. The label is "hdmi" but it's a DP endpoint. This will confuse future readers.

**Issue 3 — pinctrl on "connector" node.** The `dp_hot_plug_det` pinctrl is attached to the `hdmi-bridge` (dp-connector) node. HPD pinctrl would more typically belong on the DP controller node (`&mdss_dp`).

The GPU enable parts (`gpucc`, `gmu`, `dispcc`, `mdss` status = "okay") and the disabling of DSI/eDP interfaces are all fine.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  9:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  6:06 [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-22  6:06 ` [PATCH 1/6] soc: qcom: rpmh-rsc: Skip TCS init when RSC is managed by firmware Graham O'Connor
2026-05-25  9:16   ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 2/6] firmware: qcom: scm: Allow EFI variable access on Radxa Dragon Q6A Graham O'Connor
2026-05-24 16:33   ` Dmitry Baryshkov
2026-05-25  9:16   ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 3/6] drm/msm/dp: Limit voltage swing level to 2 for RA620 bridge Graham O'Connor
2026-05-22  9:28   ` Konrad Dybcio
2026-05-25  9:16     ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 4/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Add regulator supplies and disable EUD Graham O'Connor
2026-05-24 16:38   ` Dmitry Baryshkov
2026-05-25  9:16   ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 5/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable GPU and display pipeline Graham O'Connor
2026-05-22  6:44   ` Neil Armstrong
2026-05-25  9:16     ` Claude Code Review Bot [this message]
2026-05-22  6:06 ` [PATCH 6/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable USB3 SuperSpeed Graham O'Connor
2026-05-22  6:44   ` Neil Armstrong
2026-05-25  9:16     ` Claude review: " Claude Code Review Bot
2026-05-22 10:13 ` [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-24  1:58   ` Xilin Wu
2026-05-25  9:16 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-def01730-bd5d-4c61-a302-a9ca625cda7a@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox