public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH 6/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable USB3 SuperSpeed
Date: Mon, 25 May 2026 19:16:37 +1000	[thread overview]
Message-ID: <review-patch6-340451f1-f397-4eb9-b6ff-8c6ae1bcefcb@linaro.org> (raw)
In-Reply-To: <340451f1-f397-4eb9-b6ff-8c6ae1bcefcb@linaro.org>

Patch Review

```dts
+&usb_1_qmpphy {
+	vdda-phy-supply = <&vreg_l6b_1p2>;
+	vdda-pll-supply = <&vreg_l1b_0p912>;
+	/delete-property/ orientation-switch;
+	status = "okay";
```

**Generally looks correct.** The use of `/delete-property/ orientation-switch` is appropriate since this is a fixed USB-A connector (no orientation detection needed). The lane assignment with DP on lanes 0-1 and USB3 SS on lanes 2-3 follows the standard QMP combo PHY split.

```dts
+	usb3_con: connector {
+		compatible = "usb-a-connector";
```

The USB-A connector node with dual-port (HS + SS) configuration is properly structured.

**Minor**: The `&usb_1` node sets `dr_mode = "host"` but doesn't set `status = "okay"` for the DWC3 child. If the base DTS has the DWC3 disabled, USB won't work. However, this depends on the base DTS defaults which may already have it enabled.

**Minor**: The `&usb_1_dwc3_hs` endpoint override is placed between the connector block and the `&usb_1` block, which works but reads slightly disjointed.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  9:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  6:06 [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-22  6:06 ` [PATCH 1/6] soc: qcom: rpmh-rsc: Skip TCS init when RSC is managed by firmware Graham O'Connor
2026-05-25  9:16   ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 2/6] firmware: qcom: scm: Allow EFI variable access on Radxa Dragon Q6A Graham O'Connor
2026-05-24 16:33   ` Dmitry Baryshkov
2026-05-25  9:16   ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 3/6] drm/msm/dp: Limit voltage swing level to 2 for RA620 bridge Graham O'Connor
2026-05-22  9:28   ` Konrad Dybcio
2026-05-25  9:16     ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 4/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Add regulator supplies and disable EUD Graham O'Connor
2026-05-24 16:38   ` Dmitry Baryshkov
2026-05-25  9:16   ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 5/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable GPU and display pipeline Graham O'Connor
2026-05-22  6:44   ` Neil Armstrong
2026-05-25  9:16     ` Claude review: " Claude Code Review Bot
2026-05-22  6:06 ` [PATCH 6/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable USB3 SuperSpeed Graham O'Connor
2026-05-22  6:44   ` Neil Armstrong
2026-05-25  9:16     ` Claude Code Review Bot [this message]
2026-05-22 10:13 ` [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-24  1:58   ` Xilin Wu
2026-05-25  9:16 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-340451f1-f397-4eb9-b6ff-8c6ae1bcefcb@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox