From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Add regulator supplies and disable EUD
Date: Mon, 25 May 2026 19:16:37 +1000 [thread overview]
Message-ID: <review-patch4-20260522060645.4399-5-graham.oconnor@gmail.com> (raw)
In-Reply-To: <20260522060645.4399-5-graham.oconnor@gmail.com>
Patch Review
```dts
+&qfprom {
+ vcc-supply = <&vreg_l1c_1p8>;
+};
+
+&pcie0 {
+ vdda-supply = <&vreg_l1c_1p8>;
+ vddpe-3v3-supply = <&vreg_bob_3p296>;
+};
+
+&pcie1 {
+ vdda-supply = <&vreg_l1c_1p8>;
+ vddpe-3v3-supply = <&vreg_bob_3p296>;
+};
+
+&eud {
+ status = "disabled";
+};
```
**No significant issues.** This is straightforward DTS plumbing. The `vreg_bob_3p296` for `vddpe-3v3` is within tolerance for a nominal 3.3V rail (BOB regulators commonly produce slightly non-standard voltages). Disabling EUD for normal USB operation is standard practice.
Minor: the commit message bundles two conceptually separate changes (regulator supplies + EUD disable). These could be separate patches for cleaner bisection, but it's not a hard requirement.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 6:06 [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-22 6:06 ` [PATCH 1/6] soc: qcom: rpmh-rsc: Skip TCS init when RSC is managed by firmware Graham O'Connor
2026-05-25 9:16 ` Claude review: " Claude Code Review Bot
2026-05-22 6:06 ` [PATCH 2/6] firmware: qcom: scm: Allow EFI variable access on Radxa Dragon Q6A Graham O'Connor
2026-05-24 16:33 ` Dmitry Baryshkov
2026-05-25 9:16 ` Claude review: " Claude Code Review Bot
2026-05-22 6:06 ` [PATCH 3/6] drm/msm/dp: Limit voltage swing level to 2 for RA620 bridge Graham O'Connor
2026-05-22 9:28 ` Konrad Dybcio
2026-05-25 9:16 ` Claude review: " Claude Code Review Bot
2026-05-22 6:06 ` [PATCH 4/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Add regulator supplies and disable EUD Graham O'Connor
2026-05-24 16:38 ` Dmitry Baryshkov
2026-05-25 9:16 ` Claude Code Review Bot [this message]
2026-05-22 6:06 ` [PATCH 5/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable GPU and display pipeline Graham O'Connor
2026-05-22 6:44 ` Neil Armstrong
2026-05-25 9:16 ` Claude review: " Claude Code Review Bot
2026-05-22 6:06 ` [PATCH 6/6] arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Enable USB3 SuperSpeed Graham O'Connor
2026-05-22 6:44 ` Neil Armstrong
2026-05-25 9:16 ` Claude review: " Claude Code Review Bot
2026-05-22 10:13 ` [PATCH 0/6] arm64: qcom: Enable additional hardware on Radxa Dragon Q6A Graham O'Connor
2026-05-24 1:58 ` Xilin Wu
2026-05-25 9:16 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260522060645.4399-5-graham.oconnor@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox