Claude review: gpu: nova-core: gsp: move chipset-specific parts of the boot process into a HAL

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

Large mechanical extraction. The `GspHal` trait design is clean:

```rust
+pub(super) trait GspHal: Send {
+    fn boot(&self, ...) -> Result;
+    fn post_boot(&self, ...) -> Result { Ok(()) }
+}
```

The `post_boot` default implementation is smart -- only TU102 needs it (for the sequencer), while GH100 can skip it.

The HAL dispatch via static references is efficient:

```rust
+pub(super) fn gsp_hal(chipset: Chipset) -> &'static dyn GspHal {
+    match chipset.arch() {
+        Architecture::Turing | Architecture::Ampere | Architecture::Ada => tu102::TU102_HAL,
+        Architecture::Hopper | Architecture::BlackwellGB10x | Architecture::BlackwellGB20x => {
+            gh100::GH100_HAL
+        }
+    }
+}
```

The `boot()` signature has `#[allow(clippy::too_many_arguments)]` with 8 parameters. This is a lot, but each parameter is necessary and this is an internal interface. A builder or context struct could reduce the parameter count but would add complexity without clear benefit at this stage.

The `boot()` receiver changes from `self: Pin<&mut Self>` to `mut self: Pin<&mut Self>` to enable `self.as_mut()` for pin projection through the HAL -- correct.

In `tu102.rs`, the `post_boot` implementation accesses `gsp.libos` and `gsp.cmdq` directly through the `Pin<&mut Gsp>`:

```rust
+        let seq_params = GspSequencerParams {
+            ...
+            libos_dma_handle: gsp.libos.dma_handle(),
+            ...
+        };
+        GspSequencer::run(&gsp.cmdq, seq_params)?;
```

This works because `libos` is not a pinned field in `Gsp` (only `logs` and `cmdq` are `#[pin]`), so direct field access through `Pin<&mut Gsp>` is fine. Wait -- `cmdq` **is** pinned, so `&gsp.cmdq` through a `Pin<&mut Gsp>` accesses the pinned field by shared reference, which is allowed since `Cmdq` likely implements the necessary access.

No blocking issues.

---

---
Generated by Claude Code Patch Reviewer