From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: shuffle boot code a bit to keep chipset-specific parts close
Date: Sat, 16 May 2026 09:54:08 +1000 [thread overview]
Message-ID: <review-patch5-20260515-nova-unload-v5-5-c4d6250ad160@nvidia.com> (raw)
In-Reply-To: <20260515-nova-unload-v5-5-c4d6250ad160@nvidia.com>
Patch Review
This patch reorders two things:
1. Moves `wpr_meta` allocation before `run_fwsec_frts()` -- benign, just memory allocation.
2. Moves `SetSystemInfo` and `SetRegistry` commands from **before** GSP falcon boot to **after** RISC-V active confirmation:
```rust
- self.cmdq
- .send_command_no_wait(bar, commands::SetSystemInfo::new(pdev))?;
- self.cmdq
- .send_command_no_wait(bar, commands::SetRegistry::new())?;
-
gsp_falcon.reset(bar)?;
...
+ self.cmdq
+ .send_command_no_wait(bar, commands::SetSystemInfo::new(pdev))?;
+ self.cmdq
+ .send_command_no_wait(bar, commands::SetRegistry::new())?;
```
The commit message says "This has no effect on the GSP boot process" which is plausible since these are `send_command_no_wait` calls that queue messages for the GSP to process later (before `wait_gsp_init_done`). However, the original placement (before falcon boot) means the commands are in the queue when the GSP starts up and begins reading. The new placement (after falcon boot) means the GSP starts, begins reading the queue, and these commands arrive while it's already running. The functional result should be the same since the GSP waits for these before signaling init done, but this is a subtle ordering change worth explicit confirmation in review that it's safe.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 6:12 [PATCH v5 0/7] gpu: nova-core: run unload sequence upon unbinding Alexandre Courbot
2026-05-15 6:12 ` [PATCH v5 1/7] gpu: nova-core: remove unneeded get_gsp_info proxy function Alexandre Courbot
2026-05-15 23:54 ` Claude review: " Claude Code Review Bot
2026-05-15 6:12 ` [PATCH v5 2/7] gpu: nova-core: do not import firmware commands into GSP command module Alexandre Courbot
2026-05-15 23:54 ` Claude review: " Claude Code Review Bot
2026-05-15 6:12 ` [PATCH v5 3/7] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command upon unloading Alexandre Courbot
2026-05-15 23:54 ` Claude review: " Claude Code Review Bot
2026-05-15 6:12 ` [PATCH v5 4/7] gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run() Alexandre Courbot
2026-05-15 23:54 ` Claude review: " Claude Code Review Bot
2026-05-15 6:12 ` [PATCH v5 5/7] gpu: nova-core: gsp: shuffle boot code a bit to keep chipset-specific parts close Alexandre Courbot
2026-05-15 23:54 ` Claude Code Review Bot [this message]
2026-05-15 6:12 ` [PATCH v5 6/7] gpu: nova-core: gsp: move chipset-specific parts of the boot process into a HAL Alexandre Courbot
2026-05-15 23:54 ` Claude review: " Claude Code Review Bot
2026-05-15 6:12 ` [PATCH v5 7/7] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Alexandre Courbot
2026-05-15 23:54 ` Claude review: " Claude Code Review Bot
2026-05-15 23:54 ` Claude review: gpu: nova-core: run unload sequence " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 6:56 [PATCH v4 0/8] " Alexandre Courbot
2026-04-27 6:57 ` [PATCH v4 6/8] gpu: nova-core: gsp: shuffle boot code a bit to keep chipset-specific parts close Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260515-nova-unload-v5-5-c4d6250ad160@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox