Claude review: gpu: nova-core: run unload sequence upon unbinding

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: nova-core: run unload sequence upon unbinding
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 8
Reviewed: 2026-05-16T09:54:07.385671

---

This is a well-structured 7-patch series from Alexandre Courbot (NVIDIA) implementing GSP firmware unloading for the nova-core driver, enabling clean GPU teardown on driver unbind. The series is at v5, rebased on the Device HRT series, and follows a logical progression: cleanup (patches 1-2), GSP shutdown command (patch 3), SEC2 refactoring (patch 4), boot code reorganization (patches 5-6 for HAL extraction), and the actual unload sequence (patch 7).

The overall design is sound: firmware required for unloading is pre-loaded at boot time (since the filesystem may not be accessible at unbind), stored in a trait-object `UnloadBundle`, and executed during the unbind path. The HAL abstraction cleanly separates the Turing/Ampere/Ada SEC2 boot path from the Hopper/Blackwell FSP path (currently a stub).

The series has appropriate reviews on the cleanup patches (1-4) from Eliot Courtney and Gary Guo, but patches 5-7 lack Reviewed-by tags. Patches 5 and 6 are described as purely mechanical but are large enough to warrant review attention.

I have a few observations, mostly minor, but one item on patch 5's reordering deserves attention.

---

---
Generated by Claude Code Patch Reviewer