public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/damage-helper: Test src coord in drm_atomic_helper_check_plane_damage()
Date: Thu, 04 Jun 2026 15:21:21 +1000	[thread overview]
Message-ID: <review-patch6-20260530185716.65688-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20260530185716.65688-7-tzimmermann@suse.de>

Patch Review

Moves the source-coordinate comparison from the runtime damage iterator into the check phase:

```c
+	if (!drm_rect_equals(&new_plane_state->src, &old_plane_state->src))
+		new_plane_state->ignore_damage_clips = true;
```

This is the right place for it -- alongside the modeset check. The function signature now takes both old and new state:
```c
void drm_atomic_helper_check_plane_damage(struct drm_atomic_commit *state,
+					  const struct drm_plane_state *old_plane_state,
+					  struct drm_plane_state *new_plane_state)
```

The corresponding removal from `drm_atomic_helper_damage_iter_init()`:
```c
-	if (!iter->clips || state->ignore_damage_clips ||
-	    !drm_rect_equals(&state->src, &old_state->src)) {
+	if (!iter->clips || state->ignore_damage_clips) {
```

Note: the `old_state` parameter is left in `damage_iter_init` for now but documented as "Unused, pass NULL". This keeps the series bisectable.

The deletion of 6 kunit tests that specifically tested src-moved scenarios is appropriate since that logic is now consolidated into the `ignore_damage_clips` flag, and the new test from patch 1 covers the flag behavior. However, the removed `drm_test_damage_iter_damage_not_visible` test checked the `visible = false` case combined with src movement -- the `visible = false` case by itself is still covered by `drm_test_damage_iter_no_damage_not_visible`, so this is fine.

**No issues.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  5:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 18:53 [PATCH v4 00/10] drm: Improve logic behind damage handling Thomas Zimmermann
2026-05-30 18:53 ` [PATCH v4 01/10] drm/damage-helper: Do not alter damage clips on modeset, but ignore them Thomas Zimmermann
2026-06-01 10:16   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 02/10] drm/atomic-helpers: Evaluate plane damage after atomic_check Thomas Zimmermann
2026-06-01 10:19   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 03/10] drm/ingenic: Remove calls to drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-06-01 10:20   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 04/10] drm/appletbdrm: Allocate request/response buffers in begin_fb_access Thomas Zimmermann
2026-06-01 10:21   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 05/10] drm/atomic_helper: Do not evaluate plane damage before atomic_check Thomas Zimmermann
2026-06-01 10:22   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 06/10] drm/damage-helper: Test src coord in drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-06-01 10:27   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude Code Review Bot [this message]
2026-05-30 18:53 ` [PATCH v4 07/10] drm/damage-helper: Remove old state from drm_atomic_helper_damage_iter_init() Thomas Zimmermann
2026-06-01 10:28   ` Javier Martinez Canillas
2026-06-01 14:01   ` Hamza Mahfooz
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 08/10] drm/damage-helper: Remove old state from drm_atomic_helper_damage_merged() Thomas Zimmermann
2026-06-01 10:29   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 09/10] drm/damage-helper: Rename state parameters in damage helpers Thomas Zimmermann
2026-06-01 10:29   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 10/10] drm/vmwgfx: Remove unused field struct vmwgfx_du_update_plane.old_state Thomas Zimmermann
2026-06-01 10:30   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-06-04  5:21 ` Claude review: drm: Improve logic behind damage handling Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 12:22 [PATCH v2 00/10] " Thomas Zimmermann
2026-05-11 12:22 ` [PATCH v2 04/10] drm/damage-helper: Test src coord in drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260530185716.65688-7-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox