public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Improve logic behind damage handling
Date: Thu, 04 Jun 2026 15:21:20 +1000	[thread overview]
Message-ID: <review-overall-20260530185716.65688-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260530185716.65688-1-tzimmermann@suse.de>

Overall Series Review

Subject: drm: Improve logic behind damage handling
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 22
Reviewed: 2026-06-04T15:21:20.564314

---

This is a well-structured 10-patch series from Thomas Zimmermann that cleans up and consolidates DRM damage clipping logic. The core insight is correct: damage evaluation was happening too early (before `atomic_check`), which meant driver `atomic_check` callbacks could trigger a modeset that invalidated the already-evaluated damage state. The series addresses this by:

1. Moving damage evaluation to **after** all `atomic_check` callbacks run
2. Using the `ignore_damage_clips` flag instead of destroying the damage blob
3. Moving src-coordinate comparison from the iterator into the check phase
4. Progressively removing the now-unnecessary `old_state` parameter from damage helpers

The series is well-ordered in v4 to avoid error-prone intermediate states, has appropriate acks/reviews from Zack Rusin and others, and includes kunit test updates. The approach is sound and the code is clean. No correctness bugs found.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  5:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 18:53 [PATCH v4 00/10] drm: Improve logic behind damage handling Thomas Zimmermann
2026-05-30 18:53 ` [PATCH v4 01/10] drm/damage-helper: Do not alter damage clips on modeset, but ignore them Thomas Zimmermann
2026-06-01 10:16   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 02/10] drm/atomic-helpers: Evaluate plane damage after atomic_check Thomas Zimmermann
2026-06-01 10:19   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 03/10] drm/ingenic: Remove calls to drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-06-01 10:20   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 04/10] drm/appletbdrm: Allocate request/response buffers in begin_fb_access Thomas Zimmermann
2026-06-01 10:21   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 05/10] drm/atomic_helper: Do not evaluate plane damage before atomic_check Thomas Zimmermann
2026-06-01 10:22   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 06/10] drm/damage-helper: Test src coord in drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-06-01 10:27   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 07/10] drm/damage-helper: Remove old state from drm_atomic_helper_damage_iter_init() Thomas Zimmermann
2026-06-01 10:28   ` Javier Martinez Canillas
2026-06-01 14:01   ` Hamza Mahfooz
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 08/10] drm/damage-helper: Remove old state from drm_atomic_helper_damage_merged() Thomas Zimmermann
2026-06-01 10:29   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 09/10] drm/damage-helper: Rename state parameters in damage helpers Thomas Zimmermann
2026-06-01 10:29   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-05-30 18:53 ` [PATCH v4 10/10] drm/vmwgfx: Remove unused field struct vmwgfx_du_update_plane.old_state Thomas Zimmermann
2026-06-01 10:30   ` Javier Martinez Canillas
2026-06-04  5:21   ` Claude review: " Claude Code Review Bot
2026-06-04  5:21 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 12:22 [PATCH v2 00/10] drm: Improve logic behind damage handling Thomas Zimmermann
2026-05-16  5:34 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260530185716.65688-1-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox