From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support
Date: Mon, 25 May 2026 22:48:49 +1000 [thread overview]
Message-ID: <review-patch8-20260519-dcss-hdmi-upstreaming-v23-8-5615524a9c63@oss.nxp.com> (raw)
In-Reply-To: <20260519-dcss-hdmi-upstreaming-v23-8-5615524a9c63@oss.nxp.com>
Patch Review
Board-level enablement for TQ's MBA8MX carrier board.
**Minor:** The `data-lanes = <0 1 2 3>;` is the identity mapping (no lane swapping). This is fine for HDMI where lane order typically matches.
---
**Summary:** The series is in good shape for v23 and most critical issues from prior reviews have been addressed. The main remaining concerns are: (1) the `cdns_mhdp_base` pointer lifetime in the PHY driver with no protection against parent unbind, (2) the data duplication of `regs`/`sapb_regs`/`dev` between `cdns_mhdp_device` and its embedded `cdns_mhdp_base`, and (3) the HDCP receiver ID buffer overflow risk in the shared mailbox helper. None are blockers but should be addressed before merge.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 12:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 14:42 [PATCH v23 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Laurentiu Palcu
2026-05-19 14:42 ` [PATCH v23 1/8] soc: cadence: Create helper functions for Cadence MHDP Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 2/8] drm: bridge: cadence: Update mhdp8546 mailbox access functions Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 3/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 4/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 5/8] dt-bindings: display: bridge: Add Cadence MHDP8501 Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 6/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 7/8] arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline Laurentiu Palcu
2026-05-25 12:48 ` Claude review: " Claude Code Review Bot
2026-05-19 14:42 ` [PATCH v23 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support Laurentiu Palcu
2026-05-25 12:48 ` Claude Code Review Bot [this message]
2026-05-25 12:48 ` Claude review: Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-07 14:31 [PATCH v21 0/8] " Laurentiu Palcu
2026-04-07 14:31 ` [PATCH v21 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260519-dcss-hdmi-upstreaming-v23-8-5615524a9c63@oss.nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox