Re: [PATCH 1/2] drm/panel: Enable DSC for Visionox VTDR6130 panel

[Neil Armstrong <neil.armstrong@linaro.org>]

On 6/4/26 15:03, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The panel driver DRM_PANEL_VISIONOX_VTDR6130 lacks Kconfig dependencies for DSC helpers, causing a linker error when compiled without them.
> --
> 
> commit 2b76aa2af63143268815713af0dc4f51234d7f43
> Author: Jun Nie <jun.nie@linaro.org>
> 
> drm/panel: Enable DSC for Visionox VTDR6130 panel
> 
> This commit enables display compression (DSC v1.2) for the 1080x2400 Visionox
> VTDR6130 AMOLED DSI panel. It sets up the DSC configuration parameters and
> sends the picture parameter set during panel initialization.
> 
>> diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>> index 97a79411e1ecd..0cdcdbbc766da 100644
>> --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>> +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
> [ ... ]
>> @@ -123,6 +128,9 @@ static int visionox_vtdr6130_on(struct visionox_vtdr6130 *ctx)
>>   	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
>>   	mipi_dsi_msleep(&dsi_ctx, 20);
>>   
>> +	drm_dsc_pps_payload_pack(&pps, dsi->dsc);
> 
> [Severity: Low]
> Will this cause a linker error if CONFIG_DRM_DISPLAY_DSC_HELPER is not enabled?

Good catch

> 
> This adds a call to drm_dsc_pps_payload_pack(), but it doesn't appear to
> update the Kconfig entry for DRM_PANEL_VISIONOX_VTDR6130 to select
> DRM_DISPLAY_DSC_HELPER and DRM_DISPLAY_HELPER.
> 
> Could this lead to undefined reference errors during the build for
> configurations where the panel is enabled but the helpers are not?
> 
>> +	mipi_dsi_picture_parameter_set_multi(&dsi_ctx, &pps);
>> +
>>   	return dsi_ctx.accum_err;
>>   }
>