public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: visionox-vtdr6130: switch to devm panel calls and drop remove
Date: Fri, 05 Jun 2026 06:24:33 +1000	[thread overview]
Message-ID: <review-patch2-20260604-topic-sm8x50-vtdr6130-dsc-v1-2-09bcd1dff1fb@linaro.org> (raw)
In-Reply-To: <20260604-topic-sm8x50-vtdr6130-dsc-v1-2-09bcd1dff1fb@linaro.org>

Patch Review

This patch converts `drm_panel_add()` + `mipi_dsi_attach()` to their devm-managed equivalents and removes the now-unnecessary `remove()` callback.

**Probe changes:**
```c
-	drm_panel_add(&ctx->panel);
-
-	ret = mipi_dsi_attach(dsi);
-	if (ret < 0) {
-		dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
-		drm_panel_remove(&ctx->panel);
+	ret = devm_drm_panel_add(dev, &ctx->panel);
+	if (ret)
 		return ret;
-	}
-
-	return 0;
+
+	return devm_mipi_dsi_attach(dev, dsi);
```

Clean conversion. The devm ordering is correct — `devm_drm_panel_add()` is called first, so on teardown the DSI detach (registered second) will happen before the panel removal. This matches the manual teardown order in the old `remove()` callback. The error path simplification (dropping `drm_panel_remove` on attach failure) is correct since devm handles it.

**Remove callback deletion:**
```c
-static void visionox_vtdr6130_remove(struct mipi_dsi_device *dsi)
-{
-	...
-}
```
and
```c
 static struct mipi_dsi_driver visionox_vtdr6130_driver = {
 	.probe = visionox_vtdr6130_probe,
-	.remove = visionox_vtdr6130_remove,
```

Both `devm_drm_panel_add()` and `devm_mipi_dsi_attach()` are available in the tree (confirmed in headers). This is a standard cleanup seen across many panel drivers.

**Verdict:** Correct, clean conversion. No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 12:41 [PATCH 0/2] drm/panel: couple of visionox vtdr6140 driver enhancements Neil Armstrong
2026-06-04 12:41 ` [PATCH 1/2] drm/panel: Enable DSC for Visionox VTDR6130 panel Neil Armstrong
2026-06-04 13:03   ` sashiko-bot
2026-06-04 14:42     ` Neil Armstrong
2026-06-04 20:24   ` Claude review: " Claude Code Review Bot
2026-06-04 12:41 ` [PATCH 2/2] drm/panel: visionox-vtdr6130: switch to devm panel calls and drop remove Neil Armstrong
2026-06-04 20:24   ` Claude Code Review Bot [this message]
2026-06-04 20:24 ` Claude review: drm/panel: couple of visionox vtdr6140 driver enhancements Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260604-topic-sm8x50-vtdr6130-dsc-v1-2-09bcd1dff1fb@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox