[PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Yicong Hui]

Fix the following W=1 kerneldoc warnings by adding the missing parameter
descriptions for @phase0_identity and @nn_interpolation in
dcss_scaler_filter_design() and @phase0_identity in
dcss_scaler_gaussian_filter()

Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'

Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
Signed-off-by: Yicong Hui <yiconghui@gmail.com>
---
 drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 32c3f46b21da..5c7f8d952ec1 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
  * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
  * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
  * @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
  * @coef: output filter coefficients
  */
 static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
  * @src_length: length of input
  * @dst_length: length of output
  * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
  * @coef: output coefficients
+ * @nn_interpolation: whether to use nearest neighbor instead of gaussian filter
  */
 static void dcss_scaler_filter_design(int src_length, int dst_length,
 				      bool use_5_taps, bool phase0_identity,
-- 
2.53.0

Claude review: drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Claude Code Review Bot]

Overall Series Review

Subject: drm/imx: Fix three kernel-doc warnings in dcss-scaler.c
Author: Yicong Hui <yiconghui@gmail.com>
Patches: 1
Reviewed: 2026-04-12T14:25:40.792927

---

This is a single-patch series that adds missing kernel-doc parameter descriptions for two static functions in `dcss-scaler.c`. It fixes three W=1 build warnings. The patch is trivial, correct, and well-formed.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Claude Code Review Bot]

Patch Review

**Status: Looks good**

The patch adds three missing `@param` entries to kernel-doc comments:

1. `@phase0_identity` in `dcss_scaler_gaussian_filter()` (line 169) — description "whether to override phase 0 coefficients with identity filter" accurately matches the usage at line 227:
   ```c
   /* override phase 0 with identity filter if specified */
   if (phase0_identity)
       for (i = 0; i < PSC_NUM_TAPS; i++)
           coef[0][i] = i == (PSC_NUM_TAPS >> 1) ?
                       (1 << PSC_COEFF_PRECISION) : 0;
   ```

2. `@phase0_identity` in `dcss_scaler_filter_design()` (line 266) — same description, parameter is passed through to `dcss_scaler_gaussian_filter()`. Accurate.

3. `@nn_interpolation` in `dcss_scaler_filter_design()` (line 268) — description "whether to use nearest neighbor instead of gaussian filter" accurately matches the usage at line 283:
   ```c
   if (nn_interpolation)
       dcss_scaler_nearest_neighbor_filter(use_5_taps, coef);
   else
       dcss_scaler_gaussian_filter(fc_q, use_5_taps, phase0_identity, coef);
   ```

**Minor nit (non-blocking):** In `dcss_scaler_filter_design()`, the `@coef` and `@nn_interpolation` doc entries are ordered as `@coef` then `@nn_interpolation`, but the function signature has `coef` before `nn_interpolation` too — so the ordering is correct. Good.

**On the Fixes tag:** The `Fixes:` tag pointing to the original commit `9021c317b770` ("drm/imx: Add initial support for DCSS on iMX8MQ") is technically correct since that's where the undocumented parameters were introduced, though using `Fixes:` for a kernel-doc-only change is debatable — this isn't fixing a functional bug. It's common practice either way, so this is just a style observation.

**Verdict:** Patch is correct and ready to apply. The descriptions are accurate, the parameter order in the doc comments matches the function signatures, and the three W=1 warnings will be resolved.

---
Generated by Claude Code Patch Reviewer