[PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

[PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

[Chen-Yu Tsai]

Sparse reports:

    exynos_drm_fimd.c:992:39: warning: incorrect type in initializer (different address spaces)
    exynos_drm_fimd.c:992:39:    expected void *timing_base
    exynos_drm_fimd.c:992:39:    got void [noderef] __iomem *
    exynos_drm_fimd.c:1005:33: warning: incorrect type in argument 1 (different address spaces)
    exynos_drm_fimd.c:1005:33:    expected void const volatile [noderef] __iomem *addr
    exynos_drm_fimd.c:1005:33:    got void *
    exynos_drm_fimd.c:1007:33: warning: incorrect type in argument 2 (different address spaces)
    exynos_drm_fimd.c:1007:33:    expected void volatile [noderef] __iomem *addr
    exynos_drm_fimd.c:1007:33:    got void *

Add "__iomem" to *timing_base to fix its type.

Fixes: 3854fab24e89 ("drm/exynos: fimd: support LCD I80 interface")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
random warning I found while checking for the size_t warning.
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index b6abdc4f2b0a..695d3515d421 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -989,7 +989,7 @@ static void fimd_trigger(struct device *dev)
 {
 	struct fimd_context *ctx = dev_get_drvdata(dev);
 	const struct fimd_driver_data *driver_data = ctx->driver_data;
-	void *timing_base = ctx->regs + driver_data->timing_base;
+	void __iomem *timing_base = ctx->regs + driver_data->timing_base;
 	u32 reg;
 
 	 /*
-- 
2.53.0.1213.gd9a14994de-goog

Claude review: drm/exynos/fimd: fix register offset type in fimd_trigger()

[Claude Code Review Bot]

Overall Series Review

Subject: drm/exynos/fimd: fix register offset type in fimd_trigger()
Author: Chen-Yu Tsai <wenst@chromium.org>
Patches: 1
Reviewed: 2026-04-12T13:00:10.012123

---

This is a single-patch series that fixes a sparse warning in the Exynos FIMD display driver. The fix is trivially correct and straightforward.

**Verdict: Looks good.** No issues found.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/exynos/fimd: fix register offset type in fimd_trigger()

[Claude Code Review Bot]

Patch Review

**Status: Clean, correct fix.**

The `ctx->regs` field is declared as `void __iomem *regs` (line 182 of `exynos_drm_fimd.c`). When `fimd_trigger()` computes a derived pointer from it:

```c
-	void *timing_base = ctx->regs + driver_data->timing_base;
+	void __iomem *timing_base = ctx->regs + driver_data->timing_base;
```

the old code drops the `__iomem` address space annotation, which causes sparse to rightfully complain when `timing_base` is later passed to `readl()` and `writel()` (lines 1005 and 1007), which expect `__iomem`-qualified pointers.

Adding `__iomem` to the local variable type makes the types consistent throughout the function. This is a no-op change at the binary level (sparse annotations have no runtime effect) but improves static analysis coverage.

The `Fixes:` tag correctly points to commit `3854fab24e89` which introduced the `fimd_trigger()` function with the original type mismatch.

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer