public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon
@ 2026-04-09  7:26 Thomas Zimmermann
  2026-04-09  8:13 ` Helge Deller
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2026-04-09  7:26 UTC (permalink / raw)
  To: deller, simona; +Cc: dri-devel, linux-fbdev, linux-kernel, Thomas Zimmermann

Add an own entry for the framebuffer console code, which is jointly
used by the fbdev and DRM drivers.

v2:
- add Helge as maintainer
- list font and include files
- update commit message (Helge)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 MAINTAINERS | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8e80296449ba..66769dcf5faa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10091,6 +10091,29 @@ S:	Maintained
 W:	https://floatingpoint.billm.au/
 F:	arch/x86/math-emu/
 
+FRAMEBUFFER CONSOLE
+M:	Helge Deller <deller@gmx.de>
+M:	Thomas Zimmermann <tzimmermann@suse.de>
+L:	dri-devel@lists.freedesktop.org
+L:	linux-fbdev@vger.kernel.org
+S:	Maintained
+T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
+F:	Documentation/fb/fbcon.rst
+F:	drivers/video/fbdev/core/bitblit.c
+F:	drivers/video/fbdev/core/fb_logo.c
+F:	drivers/video/fbdev/core/fbcon.c
+F:	drivers/video/fbdev/core/fbcon.h
+F:	drivers/video/fbdev/core/fbcon_ccw.c
+F:	drivers/video/fbdev/core/fbcon_cw.c
+F:	drivers/video/fbdev/core/fbcon_rotate.c
+F:	drivers/video/fbdev/core/fbcon_rotate.h
+F:	drivers/video/fbdev/core/fbcon_ud.c
+F:	drivers/video/fbdev/core/softcursor.c
+F:	drivers/video/fbdev/core/tileblit.c
+F:	include/linux/fbcon.h
+F:	include/linux/font.h
+F:	lib/fonts/
+
 FRAMEBUFFER CORE
 M:	Simona Vetter <simona@ffwll.ch>
 S:	Odd Fixes
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon
  2026-04-09  7:26 [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon Thomas Zimmermann
@ 2026-04-09  8:13 ` Helge Deller
  2026-04-12  1:31 ` Claude review: " Claude Code Review Bot
  2026-04-12  1:31 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2026-04-09  8:13 UTC (permalink / raw)
  To: Thomas Zimmermann, simona; +Cc: dri-devel, linux-fbdev, linux-kernel

On 4/9/26 09:26, Thomas Zimmermann wrote:
> Add an own entry for the framebuffer console code, which is jointly
> used by the fbdev and DRM drivers.
> 
> v2:
> - add Helge as maintainer
> - list font and include files
> - update commit message (Helge)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   MAINTAINERS | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
applied.

Thanks!
Helge

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: MAINTAINERS: Add dedicated entry for fbcon
  2026-04-09  7:26 [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon Thomas Zimmermann
  2026-04-09  8:13 ` Helge Deller
  2026-04-12  1:31 ` Claude review: " Claude Code Review Bot
@ 2026-04-12  1:31 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-04-12  1:31 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: MAINTAINERS: Add dedicated entry for fbcon
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 2
Reviewed: 2026-04-12T11:31:38.686399

---

This is a single, straightforward MAINTAINERS patch (v2) that carves out a dedicated entry for the framebuffer console (fbcon) code. The change is clean and well-motivated: fbcon is shared infrastructure used by both fbdev and DRM drivers, so giving it its own MAINTAINERS entry with explicit maintainers and file listings makes `get_maintainer.pl` output more useful and clarifies ownership.

All listed files exist in the tree. The entry is correctly alphabetically placed (between "FLOATING POINT EMULATION" and "FRAMEBUFFER CORE"). The format follows MAINTAINERS conventions properly.

No issues found. This looks good to merge.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: MAINTAINERS: Add dedicated entry for fbcon
  2026-04-09  7:26 [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon Thomas Zimmermann
  2026-04-09  8:13 ` Helge Deller
@ 2026-04-12  1:31 ` Claude Code Review Bot
  2026-04-12  1:31 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-04-12  1:31 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Correctness of the entry format:** The entry follows standard MAINTAINERS format correctly -- `M:` for maintainers, `L:` for mailing lists, `S:` for status, `T:` for tree, `F:` for files. All fields are properly formatted.

**Maintainers (M:):** Lists Helge Deller and Thomas Zimmermann. Helge is already the maintainer of the FRAMEBUFFER LAYER entry, so his inclusion here is consistent. Thomas is a well-known DRM/fbdev contributor at SUSE.

**Mailing lists (L:):** Lists both `dri-devel@lists.freedesktop.org` and `linux-fbdev@vger.kernel.org`, which makes sense since fbcon straddles both DRM and fbdev.

**Tree (T:):** Points to `git https://gitlab.freedesktop.org/drm/misc/kernel.git`, matching the FRAMEBUFFER CORE entry. This is the drm-misc tree, which is appropriate since fbcon patches often come through the DRM tree.

**File coverage:** All 13 listed files/directories exist in the tree:
- `Documentation/fb/fbcon.rst` -- fbcon documentation
- `drivers/video/fbdev/core/bitblit.c`, `fb_logo.c`, `fbcon.c`, `fbcon.h`, `fbcon_ccw.c`, `fbcon_cw.c`, `fbcon_rotate.c`, `fbcon_rotate.h`, `fbcon_ud.c`, `softcursor.c`, `tileblit.c` -- all fbcon core files
- `include/linux/fbcon.h`, `include/linux/font.h` -- related headers
- `lib/fonts/` -- font library directory

**Overlap consideration:** The existing FRAMEBUFFER CORE entry uses `F: drivers/video/fbdev/core/` which is a wildcard covering all files in that directory, including the fbcon files now explicitly listed. Similarly, FRAMEBUFFER LAYER uses `F: drivers/video/` and `F: Documentation/fb/` which overlap. This is fine and intentional -- `get_maintainer.pl` handles overlapping entries by reporting all matching maintainers, and having a more specific entry ensures fbcon patches get routed to the right people. The explicit file listing (rather than a wildcard like `F: drivers/video/fbdev/core/fbcon*`) is more verbose but ensures files like `bitblit.c`, `softcursor.c`, and `tileblit.c` that don't start with `fbcon` are correctly captured.

**One minor observation:** `include/linux/font.h` and `lib/fonts/` are font-related rather than fbcon-specific, and are also used outside of fbcon (e.g., by DRM drivers for boot logos). Including them here is reasonable since fbcon is the primary consumer, but it's worth noting that patches to `lib/fonts/` will now also CC the fbcon maintainers, which seems appropriate.

**Verdict:** Looks good. No changes needed.

Reviewed-by for this patch would be appropriate.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-12  1:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-09  7:26 [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon Thomas Zimmermann
2026-04-09  8:13 ` Helge Deller
2026-04-12  1:31 ` Claude review: " Claude Code Review Bot
2026-04-12  1:31 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox