From: Gilles Risch <gilles.risch@gmail.com>
To: alexander.deucher@amd.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
lkp@intel.com, Gilles Risch <gilles.risch@gmail.com>
Subject: [PATCH v3 0/2] drm/radeon: fix iMac11,1 dark display
Date: Mon, 18 May 2026 23:14:09 +0200 [thread overview]
Message-ID: <20260518211409.4868-3-gilles.risch@gmail.com> (raw)
In-Reply-To: <CADnq5_PhXmCNOGz9zK8mz7Y0Jw-J9uexhVjGLRqMA4AOHsJ5TQ@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
Hello Alex,
thank you for the feedback. I've updated the patch to use dmi_match()
as suggested, limited to iMac11,1 only since that is the only machine
I have tested so far.
I will have access to other older Apple iMacs which also show display
issues under Linux. Given your comment about unusual wiring and
potentially broken atom tables on these machines, it would make sense
to investigate this more thoroughly in the long run. I would be happy
to help with testing if that would be useful.
The build error reported by the kernel test robot is also fixed ��� the
previous version was missing the dependency on the ASIC_IS_DCE31()
macro introduced in patch 1. Both patches are now submitted together
as a series.
Changes in v3:
- Submit both patches together as a series to fix the build dependency
- Use dmi_match(DMI_PRODUCT_NAME, "iMac11,1") instead of
ASIC_IS_DCE31() to avoid breaking other DCE3.x boards
(suggested by Alex Deucher)
- Limit fix to iMac11,1 only (only tested machine)
Tested on iMac11,1 with Debian Linux.
Gilles Risch (2):
drm/radeon: fix internal display on iMac11,1 (RV770/DCE3.1)
drm/radeon: fix eDP resume from suspend on iMac11,1 / DCE3.1 systems
drivers/gpu/drm/radeon/atombios_crtc.c | 4 ++--
drivers/gpu/drm/radeon/atombios_encoders.c | 16 +++++++++-------
drivers/gpu/drm/radeon/radeon.h | 1 +
3 files changed, 12 insertions(+), 9 deletions(-)
base-commit: 6916d5703ddf9a38f1f6c2cc793381a24ee914c6
--
2.47.3
next prev parent reply other threads:[~2026-05-19 7:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 18:54 [PATCH] The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine Gilles Risch
2026-05-16 5:26 ` Claude review: " Claude Code Review Bot
2026-05-16 5:26 ` Claude Code Review Bot
2026-05-16 9:24 ` [PATCH v2] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-16 18:09 ` Lukas Wunner
2026-05-17 13:53 ` Gilles Risch
2026-05-17 14:05 ` Lukas Wunner
2026-05-18 6:36 ` Claude review: " Claude Code Review Bot
2026-05-16 18:52 ` [PATCH] drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Gilles Risch
2026-05-17 3:28 ` kernel test robot
2026-06-04 3:37 ` Claude review: " Claude Code Review Bot
2026-05-17 5:12 ` kernel test robot
2026-05-18 14:13 ` Alex Deucher
2026-05-18 14:40 ` Gilles Risch
2026-05-18 14:57 ` Alex Deucher
2026-05-18 21:14 ` Gilles Risch [this message]
2026-06-04 3:37 ` Claude review: drm/radeon: fix iMac11,1 dark display Claude Code Review Bot
2026-05-18 21:14 ` [PATCH v3 1/2] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-19 13:35 ` Alex Deucher
2026-05-18 21:14 ` [PATCH v3 2/2] drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Gilles Risch
2026-05-19 13:42 ` Alex Deucher
2026-05-27 22:20 ` [PATCH v4] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-28 18:53 ` Alex Deucher
2026-05-29 7:43 ` Gilles Risch
2026-05-29 13:31 ` Alex Deucher
2026-06-01 21:19 ` [PATCH v5] " Gilles Risch
2026-06-04 3:37 ` Claude review: drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Claude Code Review Bot
2026-05-18 6:57 ` Claude review: drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518211409.4868-3-gilles.risch@gmail.com \
--to=gilles.risch@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox