From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems
Date: Thu, 04 Jun 2026 13:37:52 +1000 [thread overview]
Message-ID: <review-patch4-20260516185226.3005-1-gilles.risch@gmail.com> (raw)
In-Reply-To: <20260516185226.3005-1-gilles.risch@gmail.com>
Patch Review
Superseded by v4/v5. The v3 2/2 patch narrowed the resume fix to `dmi_match("iMac11,1")`, which was the right direction. However:
In `atombios_set_edp_panel_power()` (v3 2/2):
```c
if (!ASIC_IS_DCE4(rdev))
if (!dmi_match(DMI_PRODUCT_NAME, "iMac11,1"))
goto done;
```
This has an **indentation/style issue** — the nested if without braces is confusing and uses spaces instead of tabs. It should be:
```c
if (!ASIC_IS_DCE4(rdev) && !dmi_match(DMI_PRODUCT_NAME, "iMac11,1"))
goto done;
```
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 3:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 18:54 [PATCH] The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine Gilles Risch
2026-05-16 5:26 ` Claude review: " Claude Code Review Bot
2026-05-16 5:26 ` Claude Code Review Bot
2026-05-16 9:24 ` [PATCH v2] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-16 18:09 ` Lukas Wunner
2026-05-17 13:53 ` Gilles Risch
2026-05-17 14:05 ` Lukas Wunner
2026-05-18 6:36 ` Claude review: " Claude Code Review Bot
2026-05-16 18:52 ` [PATCH] drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Gilles Risch
2026-05-17 3:28 ` kernel test robot
2026-06-04 3:37 ` Claude review: " Claude Code Review Bot
2026-05-17 5:12 ` kernel test robot
2026-05-18 14:13 ` Alex Deucher
2026-05-18 14:40 ` Gilles Risch
2026-05-18 14:57 ` Alex Deucher
2026-05-18 21:14 ` [PATCH v3 0/2] drm/radeon: fix iMac11,1 dark display Gilles Risch
2026-06-04 3:37 ` Claude review: " Claude Code Review Bot
2026-05-18 21:14 ` [PATCH v3 1/2] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-19 13:35 ` Alex Deucher
2026-05-18 21:14 ` [PATCH v3 2/2] drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Gilles Risch
2026-05-19 13:42 ` Alex Deucher
2026-05-27 22:20 ` [PATCH v4] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-28 18:53 ` Alex Deucher
2026-05-29 7:43 ` Gilles Risch
2026-05-29 13:31 ` Alex Deucher
2026-06-01 21:19 ` [PATCH v5] " Gilles Risch
2026-06-04 3:37 ` Claude Code Review Bot [this message]
2026-05-18 6:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260516185226.3005-1-gilles.risch@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox