* [PATCH] drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
@ 2026-05-30 19:57 Rosen Penev
2026-06-04 5:10 ` Claude review: " Claude Code Review Bot
2026-06-04 5:10 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-05-30 19:57 UTC (permalink / raw)
To: dri-devel
Cc: Matthew Auld, Arun Pravin, Joel Fernandes, David Airlie,
Simona Vetter, open list
gpu_buddy_print() has only one parameter (mm), but the kernel-doc also
documented a non-existent @p parameter.
Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpu/buddy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/buddy.c b/drivers/gpu/buddy.c
index eb1457376307..67533a92c247 100644
--- a/drivers/gpu/buddy.c
+++ b/drivers/gpu/buddy.c
@@ -1479,7 +1479,6 @@ EXPORT_SYMBOL(gpu_buddy_block_print);
* gpu_buddy_print - print allocator state
*
* @mm: GPU buddy manager
- * @p: GPU printer to use
*/
void gpu_buddy_print(struct gpu_buddy *mm)
{
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Claude review: drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
2026-05-30 19:57 [PATCH] drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc Rosen Penev
@ 2026-06-04 5:10 ` Claude Code Review Bot
2026-06-04 5:10 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-06-04 5:10 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
Author: Rosen Penev <rosenp@gmail.com>
Patches: 1
Reviewed: 2026-06-04T15:10:52.966866
---
This is a single-patch series that fixes a trivial kernel-doc warning in `drivers/gpu/buddy.c`. The `gpu_buddy_print()` function takes only one parameter (`struct gpu_buddy *mm`), but the kernel-doc comment documented a second `@p` parameter that doesn't exist. The fix simply removes the stale `@p` line.
The patch is **correct and straightforward**. The function signature confirms there is no `@p` parameter — it was likely left behind when the function's signature was refactored (the `@p` name suggests it was once a `struct drm_printer *p` parameter, a common pattern in DRM subsystem print functions).
One minor observation: the commit message uses the tag `Assisted-by: Opencode:Big-pickle`, which is not a standard kernel tag. The recognized tag for AI-assisted contributions is currently under discussion in the kernel community, but this non-standard tag is the submitter's/maintainer's concern, not a code correctness issue.
**Recommendation:** Acceptable to merge as-is.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc
2026-05-30 19:57 [PATCH] drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc Rosen Penev
2026-06-04 5:10 ` Claude review: " Claude Code Review Bot
@ 2026-06-04 5:10 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-06-04 5:10 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Status: Looks good**
The change removes one line from the kernel-doc comment:
```c
/**
* gpu_buddy_print - print allocator state
*
* @mm: GPU buddy manager
- * @p: GPU printer to use
*/
void gpu_buddy_print(struct gpu_buddy *mm)
```
The function `gpu_buddy_print()` at line 1483 takes a single `struct gpu_buddy *mm` parameter. The `@p` documentation was stale — there is no second parameter. This would cause a kernel-doc warning (`Excess function parameter 'p' description`).
No concerns with this patch.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-04 5:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 19:57 [PATCH] drm: buddy: remove stale @p parameter from gpu_buddy_print kernel-doc Rosen Penev
2026-06-04 5:10 ` Claude review: " Claude Code Review Bot
2026-06-04 5:10 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox