* [PATCH v2] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible
@ 2026-06-02 6:51 Yijie Yang
2026-06-04 3:12 ` Claude review: " Claude Code Review Bot
2026-06-04 3:12 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Yijie Yang @ 2026-06-02 6:51 UTC (permalink / raw)
To: Srinivas Kandagatla, Amol Maheshwari, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel, Yijie Yang
Document compatible string for the FastRPC interface on the Qualcomm Maili
SoC, which is compatible with the Qualcomm Kaanapali FastRPC and can
fallback to Kaanapali.
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
---
Changes in v2:
- Drop Assisted-by tag; no functional change.
- Link to v1: https://patch.msgid.link/20260525-fastrpc-v1-1-ae9add881952@oss.qualcomm.com
---
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
index 2876fdd7c6e6..afe52296bf1d 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
@@ -26,6 +26,7 @@ properties:
- enum:
- qcom,glymur-fastrpc
- qcom,hawi-fastrpc
+ - qcom,maili-fastrpc
- const: qcom,kaanapali-fastrpc
label:
---
base-commit: 550604d6c9b9efc8d068aff94dc301694a7afdee
change-id: 20260512-fastrpc-9f3b691f8e2d
Best regards,
--
Yijie Yang <yijie.yang@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Claude review: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible
2026-06-02 6:51 [PATCH v2] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible Yijie Yang
@ 2026-06-04 3:12 ` Claude Code Review Bot
2026-06-04 3:12 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-06-04 3:12 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Commit message**: Clear and concise. States what the patch does and notes that Maili is compatible with and falls back to Kaanapali. Good.
**Change itself**:
```yaml
- enum:
- qcom,glymur-fastrpc
- qcom,hawi-fastrpc
+ - qcom,maili-fastrpc
- const: qcom,kaanapali-fastrpc
```
- Correctly adds the new compatible inside the `items:` list where the first element is the SoC-specific compatible and the second is the `qcom,kaanapali-fastrpc` fallback. This follows the established pattern.
- Alphabetical ordering is maintained (`glymur` < `hawi` < `maili`).
- The YAML indentation matches the surrounding context.
**No issues found.** This is a clean, minimal dt-bindings patch.
**Reviewed-by worthy**: Yes, no concerns with this patch.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread* Claude review: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible
2026-06-02 6:51 [PATCH v2] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible Yijie Yang
2026-06-04 3:12 ` Claude review: " Claude Code Review Bot
@ 2026-06-04 3:12 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-06-04 3:12 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible
Author: Yijie Yang <yijie.yang@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-06-04T13:12:22.346708
---
This is a single-patch series adding a new compatible string (`qcom,maili-fastrpc`) to the Qualcomm FastRPC device tree binding. The patch is trivial and straightforward — it adds a new SoC-specific compatible that falls back to the existing `qcom,kaanapali-fastrpc` compatible, following the established pattern in the binding.
The change is correct and properly placed in alphabetical order within the enum list. No functional concerns.
However, there is a discrepancy between the **patch base** and the **current drm-next tree**: the binding on drm-next (shown above) only has `qcom,glymur-fastrpc` in the inner enum (lines 27-28), while the patch context shows both `qcom,glymur-fastrpc` and `qcom,hawi-fastrpc`. This means the patch is based on a tree that already includes the `qcom,hawi-fastrpc` addition (likely already queued elsewhere), which explains why it didn't apply cleanly. This is not a problem with the patch itself — it just needs to be applied on top of the tree that includes the `hawi` entry.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-04 3:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 6:51 [PATCH v2] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible Yijie Yang
2026-06-04 3:12 ` Claude review: " Claude Code Review Bot
2026-06-04 3:12 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox