public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma/contiguous: Fix broken build
Date: Tue, 31 Mar 2026 17:29:36 +1000	[thread overview]
Message-ID: <review-overall-20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> (raw)
In-Reply-To: <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org>

Overall Series Review

Subject: dma/contiguous: Fix broken build
Author: Maxime Ripard <mripard@kernel.org>
Patches: 5
Reviewed: 2026-03-31T17:29:36.009744

---

This is a single-patch build fix for a regression introduced by commit `3a236f6a5cf2` ("dma: contiguous: Turn heap registration logic around"). That commit changed the CMA heap registration model so the CMA heap driver discovers CMA areas itself (via `dev_get_cma_area()` in `add_cma_heaps()`), but left behind one stale call to the now-removed `dma_heap_cma_register_heap()` in `dma_contiguous_reserve()`, breaking the build.

The fix is clean and correct: it removes the dead call, deletes the now-empty header, and removes all includes of that header. The only two files that included the header (`cma_heap.c` and `contiguous.c`) are both addressed.

**Verdict: Looks good.** One minor nit on the commit message wording below.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-31  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260330084111eucas1p1e7cd5c886e34d0ed41226fe524d2a55a@eucas1p1.samsung.com>
2026-03-30  8:40 ` [PATCH] dma/contiguous: Fix broken build Maxime Ripard
2026-03-30  8:59   ` Marek Szyprowski
2026-03-30 11:41     ` Maxime Ripard
2026-03-30 12:51       ` Marek Szyprowski
2026-03-30 15:40         ` Maxime Ripard
2026-03-31  7:29   ` Claude review: " Claude Code Review Bot
2026-03-31  7:29   ` Claude Code Review Bot [this message]
2026-03-30 15:40 [PATCH v2] " Maxime Ripard
2026-03-31  7:07 ` Claude review: " Claude Code Review Bot
2026-03-31  7:07 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox