From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma/contiguous: Fix broken build
Date: Tue, 31 Mar 2026 17:29:36 +1000 [thread overview]
Message-ID: <review-patch1-20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> (raw)
In-Reply-To: <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org>
Patch Review
**Correctness:** The patch is correct. The default CMA region is already handled by `add_cma_heaps()` in `cma_heap.c` which calls `dev_get_cma_area(NULL)` to retrieve it, so the removed call in `dma_contiguous_reserve()` was indeed redundant/dead:
```c
- ret = dma_heap_cma_register_heap(dma_contiguous_default_area);
- if (ret)
- pr_warn("Couldn't register default CMA heap.");
```
The header deletion is appropriate — after the parent commit removed the function definition, the header contained only a declaration with no remaining users:
```c
-int dma_heap_cma_register_heap(struct cma *cma);
```
**Completeness:** All include sites of `linux/dma-buf/heaps/cma.h` are covered (only `cma_heap.c` and `contiguous.c`). No other callers of `dma_heap_cma_register_heap()` remain after the parent commit.
**Minor nit (commit message only):** The commit message says "the now unused function definition" but the header file contains a function *declaration* (and an inline stub for the `!CONFIG_DMABUF_HEAPS_CMA` case). The actual function *definition* was in `cma_heap.c` and was presumably removed by the parent commit. This is a cosmetic issue in the commit message and doesn't affect the code.
**Reviewed-by worthy:** Yes, this is a straightforward and correct build fix.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260330084111eucas1p1e7cd5c886e34d0ed41226fe524d2a55a@eucas1p1.samsung.com>
2026-03-30 8:40 ` [PATCH] dma/contiguous: Fix broken build Maxime Ripard
2026-03-30 8:59 ` Marek Szyprowski
2026-03-30 11:41 ` Maxime Ripard
2026-03-30 12:51 ` Marek Szyprowski
2026-03-30 15:40 ` Maxime Ripard
2026-03-31 7:29 ` Claude review: " Claude Code Review Bot
2026-03-31 7:29 ` Claude Code Review Bot [this message]
2026-03-30 15:40 [PATCH v2] " Maxime Ripard
2026-03-31 7:07 ` Claude review: " Claude Code Review Bot
2026-03-31 7:07 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox