From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma/contiguous: Fix broken build
Date: Tue, 31 Mar 2026 17:07:44 +1000 [thread overview]
Message-ID: <review-overall-20260330-dma-build-fix-v2-1-26d844575815@kernel.org> (raw)
In-Reply-To: <20260330-dma-build-fix-v2-1-26d844575815@kernel.org>
Overall Series Review
Subject: dma/contiguous: Fix broken build
Author: Maxime Ripard <mripard@kernel.org>
Patches: 2
Reviewed: 2026-03-31T17:07:44.040479
---
This is a single-patch build fix from Maxime Ripard addressing a broken build caused by commit 3a236f6a5cf2 ("dma: contiguous: Turn heap registration logic around") which removed the definition of `dma_heap_cma_register_heap()` but left behind a call site in `dma_contiguous_reserve()`.
The fix is logically sound: it replaces the dangling call with `rmem_cma_insert_area()` (introduced by the same broken commit), removes the now-empty header `linux/dma-buf/heaps/cma.h`, and cleans up all includes of it. The approach of queueing the CMA area via `rmem_cma_insert_area()` instead of directly registering the heap aligns with the new registration architecture that 3a236f6a5cf2 intended.
There are a couple of minor observations but nothing blocking.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260330154021eucas1p1ddf347acd21646c96fda4b266ddfc03b@eucas1p1.samsung.com>
2026-03-30 15:40 ` [PATCH v2] dma/contiguous: Fix broken build Maxime Ripard
2026-03-30 17:49 ` Marek Szyprowski
2026-03-31 7:07 ` Claude Code Review Bot [this message]
2026-03-31 7:07 ` Claude review: " Claude Code Review Bot
2026-03-30 8:40 [PATCH] " Maxime Ripard
2026-03-31 7:29 ` Claude review: " Claude Code Review Bot
2026-03-31 7:29 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260330-dma-build-fix-v2-1-26d844575815@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox