Claude review: drm/panthor: Localize register access by component

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/panthor: Localize register access by component
Author: Karunika Choo <karunika.choo@arm.com>
Patches: 13
Reviewed: 2026-04-13T19:05:51.523061

---

This is a well-structured refactoring series that localizes register accesses in the panthor driver by giving each component (GPU, PWR, FW, MMU) its own `void __iomem *` base pointer instead of routing all accesses through `ptdev->iomem`. The series proceeds in logical steps:

1. First, make `gpu_read`/`gpu_write` helpers take a raw `void __iomem *` (patch 1)
2. Split the monolithic register header by component (patch 2)
3. Eliminate cross-component register accesses (patch 3)
4. Generalize IRQ register handling (patch 4)
5. Then convert each component one at a time (patches 5–8)

The register address arithmetic is correct throughout — I verified the base offsets (GPU_CONTROL at 0x0, MCU_CONTROL at 0x700, PWR_CONTROL at 0x800, MMU_AS at 0x2400) and the rebased per-component register defines. Initialization ordering is safe: `panthor_gpu_init()` runs before `panthor_gpu_coherency_init()`, so `ptdev->gpu->iomem` is valid when needed.

**Overall verdict:** This is a clean, mechanical refactoring with no functional changes. The series is ready to merge with minor observations noted below. The patches that already have Boris Brezillon's Acked-by (1, 7, 8) look correct, and the remaining patches are equally sound.

**One pre-existing bug noted** (not introduced by this series): `panthor_pwr_l2_power_on()` truncates a 64-bit register read to `u32`.

---

---
Generated by Claude Code Patch Reviewer