public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Use a local iomem base for PWR registers
Date: Mon, 13 Apr 2026 19:05:53 +1000	[thread overview]
Message-ID: <review-patch6-20260412142951.2309135-7-karunika.choo@arm.com> (raw)
In-Reply-To: <20260412142951.2309135-7-karunika.choo@arm.com>

Patch Review

**Status: Good, with one pre-existing bug noted.**

Adds `void __iomem *iomem` to `struct panthor_pwr`, set to `ptdev->iomem + GPU_CONTROL_BASE + PWR_CONTROL_BASE`:

```c
+	pwr->iomem = ptdev->iomem + GPU_CONTROL_BASE + PWR_CONTROL_BASE;
```

Since `GPU_CONTROL_BASE` is 0x0, this effectively becomes `ptdev->iomem + 0x800`, which is correct for the power management register block.

Register defines are rebased — for example, `TILER_PWRTRANS` changes from a `PWR_CTRL_REG()` macro invocation to a plain offset relative to PWR_CONTROL_BASE:

```c
-#define TILER_PWRTRANS			PWR_CTRL_REG(0x18)
+#define TILER_PWRTRANS			0x18
```

The IRQ iomem for PWR is set to `ptdev->iomem + PWR_INT_BASE` where `PWR_INT_BASE` becomes 0x800 (same as `PWR_CONTROL_BASE`). Looking at the Mali register map, the PWR interrupt registers are indeed at offset 0x800 from the GPU base — this is because the PWR_INT registers happen to be at the start of the PWR block. Correct.

**Pre-existing bug (not introduced by this series):** In `panthor_pwr_l2_power_on()`:

```c
 	const u32 pwr_status = gpu_read64(pwr->iomem, L2_PWRTRANS);
```

`gpu_read64` returns `u64`, but the result is stored in a `u32`. This silently truncates the upper 32 bits. For current hardware with ≤32 shader cores this is harmless, but it's technically wrong. This truncation exists in the current code as well — the patch merely changes the iomem argument, not the type. Worth fixing separately.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-13  9:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 14:29 [PATCH v2 0/8] drm/panthor: Localize register access by component Karunika Choo
2026-04-12 14:29 ` [PATCH v2 1/8] drm/panthor: Pass an iomem pointer to GPU register access helpers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 2/8] drm/panthor: Split register definitions by components Karunika Choo
2026-04-13  7:43   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 3/8] drm/panthor: Replace cross-component register accesses with helpers Karunika Choo
2026-04-13  7:44   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 4/8] drm/panthor: Store IRQ register base iomem pointer in panthor_irq Karunika Choo
2026-04-13  7:46   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 5/8] drm/panthor: Use a local iomem base for GPU registers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-13  7:51   ` Boris Brezillon
2026-04-13  9:05   ` Claude Code Review Bot [this message]
2026-04-12 14:29 ` [PATCH v2 7/8] drm/panthor: Use a local iomem base for firmware control registers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 8/8] drm/panthor: Use a local iomem base for MMU AS registers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-13  9:05 ` Claude review: drm/panthor: Localize register access by component Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-10 16:46 [PATCH 0/8] " Karunika Choo
2026-04-10 16:46 ` [PATCH 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260412142951.2309135-7-karunika.choo@arm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox