public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Use a local iomem base for GPU registers
Date: Mon, 13 Apr 2026 19:05:52 +1000	[thread overview]
Message-ID: <review-patch5-20260412142951.2309135-6-karunika.choo@arm.com> (raw)
In-Reply-To: <20260412142951.2309135-6-karunika.choo@arm.com>

Patch Review

**Status: Good.**

Adds `void __iomem *iomem` to `struct panthor_gpu`, initialized to `ptdev->iomem + GPU_CONTROL_BASE` (offset 0x0, so identical to `ptdev->iomem`):

```c
+	gpu->iomem = ptdev->iomem + GPU_CONTROL_BASE;
```

All GPU register accesses switch from `gpu_read(ptdev->iomem, GPU_XXX)` to `gpu_read(gpu->iomem, GPU_XXX)`. Since `GPU_CONTROL_BASE` is 0x0, the register defines don't need rebasing — they retain their existing values.

For IRQ, the GPU_INT registers are at offset 0x1000 (`GPU_INT_BASE`), so the IRQ iomem is set to:
```c
+	ret = panthor_request_gpu_irq(ptdev, ptdev->iomem + GPU_INT_BASE, ...);
```

The `GPU_INT_RAWSTAT`, `GPU_INT_CLEAR`, `GPU_INT_MASK`, `GPU_INT_STAT` defines are removed since they're now handled via the generic `INT_*` offsets relative to the IRQ's iomem base. Correct.

In `panthor_hw.c`, a local variable is introduced since `panthor_hw.c` doesn't have direct access to the `panthor_gpu` struct internals:
```c
+	void __iomem *gpu_iomem = ptdev->iomem + GPU_CONTROL_BASE;
```

This is clean.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-13  9:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 14:29 [PATCH v2 0/8] drm/panthor: Localize register access by component Karunika Choo
2026-04-12 14:29 ` [PATCH v2 1/8] drm/panthor: Pass an iomem pointer to GPU register access helpers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 2/8] drm/panthor: Split register definitions by components Karunika Choo
2026-04-13  7:43   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 3/8] drm/panthor: Replace cross-component register accesses with helpers Karunika Choo
2026-04-13  7:44   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 4/8] drm/panthor: Store IRQ register base iomem pointer in panthor_irq Karunika Choo
2026-04-13  7:46   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 5/8] drm/panthor: Use a local iomem base for GPU registers Karunika Choo
2026-04-13  9:05   ` Claude Code Review Bot [this message]
2026-04-12 14:29 ` [PATCH v2 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-13  7:51   ` Boris Brezillon
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 7/8] drm/panthor: Use a local iomem base for firmware control registers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-12 14:29 ` [PATCH v2 8/8] drm/panthor: Use a local iomem base for MMU AS registers Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot
2026-04-13  9:05 ` Claude review: drm/panthor: Localize register access by component Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-10 16:46 [PATCH 0/8] " Karunika Choo
2026-04-10 16:46 ` [PATCH 5/8] drm/panthor: Use a local iomem base for GPU registers Karunika Choo
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260412142951.2309135-6-karunika.choo@arm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox