[PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()

[PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()

[sai madhu]

The DRM_ERROR() macro is deprecated in favor of drm_err() which
provides device-specific logging.

Replace DRM_ERROR() with drm_err() in the Mediatek HDMI bridge
driver and pass the drm_device pointer via bridge->dev.

No functional change intended.

Signed-off-by: sai madhu <suryasaimadhu369@gmail.com>
---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 1ea259854780..4ddcdbf7bc8c 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -981,8 +981,8 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
 	int ret;
 
 	if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
-		DRM_ERROR("%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n",
-			  __func__);
+		drm_err(bridge->dev,
+			"DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n");
 		return -EINVAL;
 	}
 
-- 
2.34.1

Claude review: drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()

[Claude Code Review Bot]

Overall Series Review

Subject: drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()
Author: sai madhu <suryasaimadhu369@gmail.com>
Patches: 1
Reviewed: 2026-04-23T10:15:07.736372

---

This is a single-patch series performing a straightforward, mechanical conversion from the deprecated `DRM_ERROR()` macro to the preferred `drm_err()` in the Mediatek HDMI bridge driver. The change is correct, complete (no remaining `DRM_ERROR` calls in the file), and introduces no functional change.

The patch is clean and ready to apply. One minor nit below.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()

[Claude Code Review Bot]

Patch Review

**Status: Looks good**

The conversion is correct:

- `bridge->dev` is `struct drm_device *` (confirmed from `drm_bridge.h:1104`), which is the correct first argument for `drm_err()`.
- The `__func__` prefix was correctly removed — `drm_err()` already includes device identification in its output, so the function name is unnecessary (and the original `__func__` usage was unusual for this kind of error message anyway).
- After the patch, no `DRM_ERROR` calls remain in `mtk_hdmi.c`, so the conversion is complete for this file.
- The error message text is clear and adequate.

**Minor nit:** The error message string says `"DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n"` — while this is functionally fine and matches the flag name, a slightly more descriptive phrasing like `"The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n"` (preserving the original's wording minus `__func__`) would be marginally clearer to someone reading logs. This is very minor and not worth blocking on.

**Verdict:** Patch is correct and complete. No issues.

---
Generated by Claude Code Patch Reviewer