public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: handle IRQ_HPD events correctly
Date: Thu, 23 Apr 2026 09:07:42 +1000	[thread overview]
Message-ID: <review-overall-20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> (raw)
In-Reply-To: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com>

Overall Series Review

Subject: drm: handle IRQ_HPD events correctly
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 8
Reviewed: 2026-04-23T09:07:42.466808

---

This is a well-structured 6-patch series from Dmitry Baryshkov that addresses a real gap in the DRM/USB-C DisplayPort AltMode subsystem: the inability to propagate IRQ_HPD (short hotplug pulses / sink attention requests) through the out-of-band hotplug path. This is critical for DP MST support over USB-C, where MST sideband messages are delivered via IRQ_HPD.

The approach is sound:
1. Introduce `enum drm_connector_status_extra` to carry additional event information alongside HPD status
2. Thread this new parameter through the connector, bridge, and aux-hpd APIs
3. Provide backward-compatible inline wrappers so existing callers don't need updating
4. Wire up consumers: MSM DP driver, PMIC GLINK altmode, and Huawei Gaokun UCSI

The layering is clean -- core API changes first, then bridge plumbing, then driver consumers. The backward-compatible wrappers (`drm_bridge_hpd_notify()`, `drm_aux_hpd_bridge_notify()`) are a pragmatic choice to avoid cross-tree merge complications.

**Minor issues found:** One typo in a commit message, one stray cosmetic change, and a question about the `_extra` naming suffix. No correctness bugs identified.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-22 23:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 23:33 [PATCH v3 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 23:33 ` [PATCH v3 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-21  9:51   ` Konrad Dybcio
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-22 23:07 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 15:31 [PATCH v2 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox