public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: handle IRQ_HPD events correctly
Date: Thu, 23 Apr 2026 09:32:08 +1000	[thread overview]
Message-ID: <review-overall-20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com> (raw)
In-Reply-To: <20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com>

Overall Series Review

Subject: drm: handle IRQ_HPD events correctly
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 7
Reviewed: 2026-04-23T09:32:08.870531

---

This is a v2 series from Dmitry Baryshkov that plumbs IRQ_HPD (short hotplug pulse / AltMode IRQ) events through the DRM connector and bridge infrastructure, from USB Type-C sources down to DisplayPort sink drivers. The motivation is solid: DP MST events are delivered via IRQ_HPD, and without this plumbing, USB-C connected DP devices with MST can't receive those notifications.

The design is reasonable -- introducing a `drm_connector_status_extra` enum to carry side-band information alongside the existing HPD status, then threading it through the relevant APIs. The v2 change from a boolean `irq_hpd` to an enum is a good extensibility choice.

However, there is a **compile-breaking bug** in patch 3, and some design concerns worth discussing around the `drm_bridge_connector_handle_hpd` path where IRQ_HPD events unconditionally trigger `drm_kms_helper_connector_hotplug_event()`, which may cause unnecessary full connector re-detection for what should be a lightweight sink IRQ.

**Critical issue count: 1 (build break)**
**Design concerns: 1-2**

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-22 23:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 15:31 [PATCH v2 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 15:31 ` [PATCH v2 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-22 23:32 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 23:33 [PATCH v3 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-22 23:07 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox