From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: dp: handle the IRQ_HPD events reported by USB-C
Date: Thu, 23 Apr 2026 09:32:09 +1000 [thread overview]
Message-ID: <review-patch4-20260420-hpd-irq-events-v2-4-402ffe27e9e9@oss.qualcomm.com> (raw)
In-Reply-To: <20260420-hpd-irq-events-v2-4-402ffe27e9e9@oss.qualcomm.com>
Patch Review
This is small and focused:
```c
if (extra_status == DRM_CONNECTOR_DP_IRQ_HPD)
msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0);
```
**This looks correct.** The `EV_IRQ_HPD_INT` event is already handled by the MSM DP event loop, so this will trigger the existing IRQ_HPD processing (DPCD reads, link retraining, MST handling etc).
One question: could an IRQ_HPD arrive simultaneously with a connect event? In that case, both `EV_HPD_PLUG_INT` and `EV_IRQ_HPD_INT` would be queued. This matches the behavior of the hardware HPD path (where both can fire independently), so it should be fine.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 23:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 15:31 [PATCH v2 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 15:31 ` [PATCH v2 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:32 ` Claude Code Review Bot [this message]
2026-04-20 15:31 ` [PATCH v2 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-22 23:32 ` Claude review: drm: handle IRQ_HPD events correctly Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 23:33 [PATCH v3 0/6] " Dmitry Baryshkov
2026-04-20 23:33 ` [PATCH v3 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260420-hpd-irq-events-v2-4-402ffe27e9e9@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox