From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event()
Date: Thu, 23 Apr 2026 09:32:09 +1000 [thread overview]
Message-ID: <review-patch1-20260420-hpd-irq-events-v2-1-402ffe27e9e9@oss.qualcomm.com> (raw)
In-Reply-To: <20260420-hpd-irq-events-v2-1-402ffe27e9e9@oss.qualcomm.com>
Patch Review
This patch introduces the `enum drm_connector_status_extra` type and extends `drm_connector_oob_hotplug_event()` and all its callers in the USB typec displayport altmode driver.
**Looks good overall.** The enum and its documentation are clear. The callers in `displayport.c` are correctly updated.
One minor observation: in the `dp_altmode_status_update()` path:
```c
drm_connector_oob_hotplug_event(dp->connector_fwnode,
hpd ? connector_status_connected :
connector_status_disconnected,
(hpd && irq_hpd) ? DRM_CONNECTOR_DP_IRQ_HPD :
DRM_CONNECTOR_NO_EXTRA_STATUS);
```
This correctly only sends IRQ_HPD when HPD is asserted (since IRQ_HPD without HPD is meaningless per DP spec). Good.
Minor nit: the cover letter says "desribing" (typo for "describing") and "chaning" (typo for "changing"), but those are in the changelog, not in code.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 23:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 15:31 [PATCH v2 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 15:31 ` [PATCH v2 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:32 ` Claude Code Review Bot [this message]
2026-04-20 15:31 ` [PATCH v2 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:32 ` Claude review: " Claude Code Review Bot
2026-04-22 23:32 ` Claude review: drm: handle IRQ_HPD events correctly Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 23:33 [PATCH v3 0/6] " Dmitry Baryshkov
2026-04-20 23:33 ` [PATCH v3 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260420-hpd-irq-events-v2-1-402ffe27e9e9@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox