public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: aux-hpd: let drivers pass IRQ_HPD events
Date: Thu, 23 Apr 2026 09:32:09 +1000	[thread overview]
Message-ID: <review-patch3-20260420-hpd-irq-events-v2-3-402ffe27e9e9@oss.qualcomm.com> (raw)
In-Reply-To: <20260420-hpd-irq-events-v2-3-402ffe27e9e9@oss.qualcomm.com>

Patch Review

**BUILD BUG:** In `include/drm/bridge/aux-bridge.h`, the `#else` stub for `drm_aux_hpd_bridge_notify_extra()` has a semicolon after the declaration instead of the function body:

```c
static inline void drm_aux_hpd_bridge_notify_extra(struct device *dev,
						   enum drm_connector_status status,
						   enum drm_connector_status_extra extra_status);
{
}
```

That trailing `;` after the parameter list makes this a declaration followed by an empty compound statement at file scope. This will fail to compile when `CONFIG_DRM_AUX_HPD_BRIDGE` is not enabled. Should be:

```c
static inline void drm_aux_hpd_bridge_notify_extra(struct device *dev,
						   enum drm_connector_status status,
						   enum drm_connector_status_extra extra_status)
{
}
```

**Also in the same header:** The `drm_aux_hpd_bridge_notify()` inline wrapper is placed **outside** the `#endif` for `CONFIG_DRM_AUX_HPD_BRIDGE`:

```c
#endif

static inline void drm_aux_hpd_bridge_notify(struct device *dev, enum drm_connector_status status)
{
	drm_aux_hpd_bridge_notify_extra(dev, status, DRM_CONNECTOR_NO_EXTRA_STATUS);
}

#endif
```

This means when `CONFIG_DRM_AUX_HPD_BRIDGE` **is** enabled, there will be **two** definitions of `drm_aux_hpd_bridge_notify()` -- one as a non-static exported function from `aux-hpd-bridge.c` (which wasn't removed in this patch; the `EXPORT_SYMBOL_GPL(drm_aux_hpd_bridge_notify)` was only renamed to `_extra`) and one as this `static inline`. Wait -- actually the exported symbol *was* renamed, and the original function body was renamed to `drm_aux_hpd_bridge_notify_extra()`. So the old `drm_aux_hpd_bridge_notify()` no longer exists as an exported function, and this inline wrapper replaces it. That part is fine.

But the placement is still questionable: the inline wrapper calls `drm_aux_hpd_bridge_notify_extra()`, which in the `!CONFIG_DRM_AUX_HPD_BRIDGE` case is the buggy stub (see above). And the wrapper sits between the two `#endif` guards. This works structurally (it's available in all configs), but the intent would be clearer if it were inside the `#if` block as well, with a corresponding stub in the `#else`.

The commit message says "The drm_aux_hpd_bridge_notify() is keps to ease merging" -- "keps" is a typo for "kept".

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 23:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 15:31 [PATCH v2 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 15:31 ` [PATCH v2 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:32   ` Claude Code Review Bot [this message]
2026-04-20 15:31 ` [PATCH v2 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-22 23:32 ` Claude review: drm: handle IRQ_HPD events correctly Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 23:33 [PATCH v3 0/6] " Dmitry Baryshkov
2026-04-20 23:33 ` [PATCH v3 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260420-hpd-irq-events-v2-3-402ffe27e9e9@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox