public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: pass down IRQ_HPD to the drivers
Date: Thu, 23 Apr 2026 09:32:09 +1000	[thread overview]
Message-ID: <review-patch2-20260420-hpd-irq-events-v2-2-402ffe27e9e9@oss.qualcomm.com> (raw)
In-Reply-To: <20260420-hpd-irq-events-v2-2-402ffe27e9e9@oss.qualcomm.com>

Patch Review

This is the large mechanical patch extending all `hpd_notify`, `hpd_cb`, `oob_hotplug_event` callbacks with the extra `extra_status` parameter.

**Concern: spurious blank line removal in ti-tfp410.c:**

```c
-
 static inline struct tfp410 *
```

This hunk removes a blank line between two functions in `ti-tfp410.c` that is unrelated to the change. Should be reverted.

**Design concern in `drm_bridge_connector_handle_hpd()`:** The function now receives `extra_status` and passes it to `drm_bridge_connector_hpd_notify()`, but it also unconditionally calls `drm_kms_helper_connector_hotplug_event(connector)` afterward. For a pure IRQ_HPD event (where status hasn't actually changed), this triggers a full connector hotplug event to userspace, which causes unnecessary reprobing. The function probably should skip calling `drm_kms_helper_connector_hotplug_event()` when the status hasn't changed and only `extra_status` was set, or use a more targeted notification path. That said, the current DP drivers handle IRQ_HPD internally (e.g., MSM adds `EV_IRQ_HPD_INT`), so this may be acceptable for now if the cost of the extra userspace notification is low.

**In `drm_bridge_hpd_notify()` (drm_bridge.c):** The patch hardcodes `DRM_CONNECTOR_NO_EXTRA_STATUS`:

```c
	if (bridge->hpd_cb)
		bridge->hpd_cb(bridge->hpd_data, status, DRM_CONNECTOR_NO_EXTRA_STATUS);
```

This is fine as a temporary measure since patch 3 introduces `drm_bridge_hpd_notify_extra()` that passes the real value, and this function becomes the legacy wrapper. The inter-patch dependency is clean.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 23:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 15:31 [PATCH v2 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 15:31 ` [PATCH v2 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:32   ` Claude Code Review Bot [this message]
2026-04-20 15:31 ` [PATCH v2 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-20 15:31 ` [PATCH v2 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot
2026-04-22 23:32 ` Claude review: drm: handle IRQ_HPD events correctly Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 23:33 [PATCH v3 0/6] " Dmitry Baryshkov
2026-04-20 23:33 ` [PATCH v3 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260420-hpd-irq-events-v2-2-402ffe27e9e9@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox