public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event()
Date: Thu, 23 Apr 2026 09:07:42 +1000	[thread overview]
Message-ID: <review-patch1-20260421-hpd-irq-events-v3-1-44d2bf40dfc2@oss.qualcomm.com> (raw)
In-Reply-To: <20260421-hpd-irq-events-v3-1-44d2bf40dfc2@oss.qualcomm.com>

Patch Review

**Design:** The new `enum drm_connector_status_extra` is well-defined with good kerneldoc. Using a separate enum rather than overloading `drm_connector_status` is the right call -- these are orthogonal concepts (connection state vs. event type).

**drm_connector.c change** -- clean and minimal. The function signature gains the extra parameter, which is threaded through to `connector->funcs->oob_hotplug_event()` (done later in patch 2).

**displayport.c changes** -- the logic is correct:

```c
(hpd && irq_hpd) ? DRM_CONNECTOR_DP_IRQ_HPD :
                   DRM_CONNECTOR_NO_EXTRA_STATUS
```

IRQ_HPD only makes sense when HPD is asserted (connected), so the `hpd && irq_hpd` guard is correct per the DP spec. The disconnect paths correctly pass `DRM_CONNECTOR_NO_EXTRA_STATUS`.

The `dp_altmode_configured()` path correctly uses `dp->pending_irq_hpd` for deferred HPD events. No issues.

**Nit:** The cover letter has "singnalling" (typo for "signalling").

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 23:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 23:33 [PATCH v3 0/6] drm: handle IRQ_HPD events correctly Dmitry Baryshkov
2026-04-20 23:33 ` [PATCH v3 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:07   ` Claude Code Review Bot [this message]
2026-04-20 23:33 ` [PATCH v3 2/6] drm/bridge: pass down IRQ_HPD to the drivers Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 3/6] drm/bridge: aux-hpd: let drivers pass IRQ_HPD events Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 4/6] drm/msm: dp: handle the IRQ_HPD events reported by USB-C Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 5/6] soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Dmitry Baryshkov
2026-04-21  9:51   ` Konrad Dybcio
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-20 23:33 ` [PATCH v3 6/6] usb: typec: ucsi: huawei-gaokun: " Dmitry Baryshkov
2026-04-22 23:07   ` Claude review: " Claude Code Review Bot
2026-04-22 23:07 ` Claude review: drm: handle IRQ_HPD events correctly Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 15:31 [PATCH v2 0/6] " Dmitry Baryshkov
2026-04-20 15:31 ` [PATCH v2 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event() Dmitry Baryshkov
2026-04-22 23:32   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260421-hpd-irq-events-v3-1-44d2bf40dfc2@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox