Claude review: Add Anbernic RG Vita-Pro

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add Anbernic RG Vita-Pro
Author: Chris Morgan <macroalpha82@gmail.com>
Patches: 8
Reviewed: 2026-04-28T14:19:01.912799

---

This is a 6-patch series adding support for the Anbernic RG Vita-Pro handheld gaming console based on the Rockchip RK3576 SoC. It introduces:
1. A new SGM41542 battery charger driver and its DT binding
2. A new Anbernic TD4310 DSI panel driver and its DT binding
3. The board compatible string and full DTS

The series is well-structured with bindings preceding drivers, and the DTS coming last. The panel driver is clean and uses modern APIs (`devm_drm_panel_alloc`, `mipi_dsi_multi_context`). The charger driver, adapted from a Rockchip BSP, carries more BSP style and has several issues that should be addressed before merging. The DTS is extensive and well-documented.

**Key issues:**
- The charger driver has a bug where `power_supply_put_battery_info` is called on a potentially invalid pointer when `power_supply_get_battery_info` fails.
- The panel driver checks return values of `gpiod_set_value_cansleep` but doesn't use them consistently in error paths.
- The DTS Makefile patch includes unrelated `rk3588s-indiedroid-nova-{tower,test}` entries.
- Several unused fields in the panel info struct (`prepare_delay`, `init_delay`, `disable_delay`, `unprepare_delay`).

---

---
Generated by Claude Code Patch Reviewer