public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: rockchip: Add Anbernic RG Vita-Pro
Date: Tue, 28 Apr 2026 14:19:03 +1000	[thread overview]
Message-ID: <review-patch6-20260427170914.5062-7-macroalpha82@gmail.com> (raw)
In-Reply-To: <20260427170914.5062-7-macroalpha82@gmail.com>

Patch Review

**Unrelated Makefile entries:**
The Makefile hunk adds two entries unrelated to this series:

```
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-indiedroid-nova-tower.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-indiedroid-nova-test.dtb
```

These should be in a separate patch or dropped. The `rk3588s-indiedroid-nova-test.dtb` name suggests a test file that shouldn't be in a mainline submission.

**`constant-charge-current-max-microamp` in battery node is 10A:**

```dts
		constant-charge-current-max-microamp = <10000000>;
```

The SGM41542 hardware maximum charge current is 3.78A. This BSP value will be clamped by the driver, but it's misleading to specify a value the hardware can't deliver. It should reflect the actual intended charge current.

**`chassis-type = "handset"`** seems wrong for a handheld gaming device. Consider `"handset"` vs a more appropriate type. While there's no perfect fit in the DT spec for a gaming handheld, `"handset"` typically implies a phone. This may be acceptable as the closest match.

**Bluetooth compatible:**

```dts
		compatible = "realtek,rtl8822cs-bt";
```

The cover letter says the WiFi chip is RTL8852BE, not RTL8822CS. Verify the Bluetooth compatible string matches the actual hardware.

**The `sdio` node has `no-sdio` set:**

```dts
&sdio {
	...
	no-sdio;
```

An SD/MMC node named `sdio` with `no-sdio` is confusing but presumably correct if the hardware muxes this as a second SD slot rather than SDIO.

**Minor: extra space in `try-power-role`:**

```dts
			try-power-role  = "sink";
```

Two spaces before `=`. Should be one.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-28  4:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 17:09 [PATCH 0/6] Add Anbernic RG Vita-Pro Chris Morgan
2026-04-27 17:09 ` [PATCH 1/6] dt-bindings: power: supply: sgm41542: document sgm41542 Chris Morgan
2026-04-28  4:19   ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 2/6] power: supply: sgm41542: Add SG Micro sgm41542 charger Chris Morgan
2026-04-28  4:19   ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 3/6] dt-bindings: display: panel: document Anbernic TD4310 panel Chris Morgan
2026-04-28  4:19   ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 4/6] drm/panel: anbernic-td4310: Add RG Vita Pro panel Chris Morgan
2026-04-28  4:19   ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 5/6] dt-bindings: arm: rockchip: Add Anbernic RG Vita-Pro Chris Morgan
2026-04-28  4:19   ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 6/6] arm64: dts: " Chris Morgan
2026-04-27 17:13   ` Chris Morgan
2026-04-28  4:19   ` Claude Code Review Bot [this message]
2026-04-28  4:19 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260427170914.5062-7-macroalpha82@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox