From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: power: supply: sgm41542: document sgm41542
Date: Tue, 28 Apr 2026 14:19:02 +1000 [thread overview]
Message-ID: <review-patch1-20260427170914.5062-2-macroalpha82@gmail.com> (raw)
In-Reply-To: <20260427170914.5062-2-macroalpha82@gmail.com>
Patch Review
Looks reasonable overall.
- The `constant-charge-current-max-microamp = <10000000>` (10A) in the example seems extremely high for a single-cell battery charger. The SGM41542 datasheet max charge current is 3780mA. This looks like a copy-paste from the DTS where the BSP value is used without validation. Consider using a realistic value in the example.
```yaml
constant-charge-current-max-microamp = <10000000>;
```
- Missing `#include` ordering: the example has `#include` directives after the battery node definition, which is unconventional. The includes should come before the body.
```yaml
battery: battery {
...
};
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
```
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 4:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 17:09 [PATCH 0/6] Add Anbernic RG Vita-Pro Chris Morgan
2026-04-27 17:09 ` [PATCH 1/6] dt-bindings: power: supply: sgm41542: document sgm41542 Chris Morgan
2026-04-28 4:19 ` Claude Code Review Bot [this message]
2026-04-27 17:09 ` [PATCH 2/6] power: supply: sgm41542: Add SG Micro sgm41542 charger Chris Morgan
2026-04-28 4:19 ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 3/6] dt-bindings: display: panel: document Anbernic TD4310 panel Chris Morgan
2026-04-28 4:19 ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 4/6] drm/panel: anbernic-td4310: Add RG Vita Pro panel Chris Morgan
2026-04-28 4:19 ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 5/6] dt-bindings: arm: rockchip: Add Anbernic RG Vita-Pro Chris Morgan
2026-04-28 4:19 ` Claude review: " Claude Code Review Bot
2026-04-27 17:09 ` [PATCH 6/6] arm64: dts: " Chris Morgan
2026-04-27 17:13 ` Chris Morgan
2026-04-28 4:19 ` Claude review: " Claude Code Review Bot
2026-04-28 4:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260427170914.5062-2-macroalpha82@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox