public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h
@ 2026-04-28  3:02 Chen Ni
  2026-04-28  3:39 ` Claude review: " Claude Code Review Bot
  2026-04-28  3:39 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2026-04-28  3:02 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li; +Cc: amd-gfx, dri-devel, linux-kernel, Chen Ni

Remove duplicate inclusion of dce/dmub_hw_lock_mgr.h in dcn42_hwseq.c to
clean up redundant code.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/gpu/drm/amd/display/dc/hwss/dcn42/dcn42_hwseq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn42/dcn42_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn42/dcn42_hwseq.c
index 46f2f9833d9e..3c28a840c17c 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn42/dcn42_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn42/dcn42_hwseq.c
@@ -35,7 +35,6 @@
 #include "dc_stream_priv.h"
 #include "dcn35/dcn35_hwseq.h"
 #include "dcn42/dcn42_hwseq.h"
-#include "dce/dmub_hw_lock_mgr.h"
 #include "dio/dcn10/dcn10_dio.h"
 
 #define DC_LOGGER \
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h
  2026-04-28  3:02 [PATCH] drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h Chen Ni
@ 2026-04-28  3:39 ` Claude Code Review Bot
  2026-04-28  3:39 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28  3:39 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h
Author: Chen Ni <nichen@iscas.ac.cn>
Patches: 1
Reviewed: 2026-04-28T13:39:57.376942

---

This is a single trivial cleanup patch that removes a duplicate `#include "dce/dmub_hw_lock_mgr.h"` from `dcn42_hwseq.c`. The fix is correct and harmless.

**Verdict: Acceptable.** No functional change, no risk.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h
  2026-04-28  3:02 [PATCH] drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h Chen Ni
  2026-04-28  3:39 ` Claude review: " Claude Code Review Bot
@ 2026-04-28  3:39 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28  3:39 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Status: Correct**

The file `dcn42_hwseq.c` included `"dce/dmub_hw_lock_mgr.h"` twice:
- Line 29 (retained): `#include "dce/dmub_hw_lock_mgr.h"` — used by `dmub_hw_lock_mgr_does_context_require_lock()` and `dmub_hw_lock_mgr_inbox0_cmd()` calls later in the file.
- Line ~38 (removed by this patch): a second, redundant `#include "dce/dmub_hw_lock_mgr.h"`.

The patch removes only the second occurrence, keeping the first. The remaining include is necessary since the file references `dmub_hw_lock_mgr_does_context_require_lock` and `dmub_hw_lock_mgr_inbox0_cmd` (lines 1032, 1039, 1054).

No issues. This is a straightforward duplicate include removal.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-28  3:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28  3:02 [PATCH] drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h Chen Ni
2026-04-28  3:39 ` Claude review: " Claude Code Review Bot
2026-04-28  3:39 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox