From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages
Date: Tue, 05 May 2026 09:13:58 +1000 [thread overview]
Message-ID: <review-overall-20260501171333.4044699-1-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260501171333.4044699-1-shuicheng.lin@intel.com>
Overall Series Review
Subject: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages
Author: Shuicheng Lin <shuicheng.lin@intel.com>
Patches: 1
Reviewed: 2026-05-05T09:13:58.409097
---
This is a single, straightforward kernel-doc cleanup patch. The problem is well-described: `struct drm_gpusvm_pages` uses `@flags.*` dotted notation in its kernel-doc comment to describe the members of the named sub-struct `drm_gpusvm_pages_flags`. Since `flags` is a named external type (not an anonymous inline struct), the kernel-doc parser does not flatten its members, producing "Excess struct member" warnings. The fix correctly removes the redundant dotted entries and replaces them with a cross-reference to the type.
The patch is correct, well-motivated, and the commit message is exemplary — it explains the parser semantics, quotes the exact warnings being fixed, and notes "No functional change."
**Verdict: Patch looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 17:13 [PATCH] drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Shuicheng Lin
2026-05-04 23:13 ` Claude review: " Claude Code Review Bot
2026-05-04 23:13 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-01 17:44 [PATCH v2] " Shuicheng Lin
2026-05-04 23:12 ` Claude review: " Claude Code Review Bot
2026-05-04 23:12 ` Claude Code Review Bot
2026-05-01 17:59 [PATCH v3] " Shuicheng Lin
2026-05-04 23:11 ` Claude review: " Claude Code Review Bot
2026-05-04 23:11 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260501171333.4044699-1-shuicheng.lin@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox