Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages
Author: Shuicheng Lin <shuicheng.lin@intel.com>
Patches: 1
Reviewed: 2026-05-05T09:12:49.244063

---

This is a single trivial kernel-doc fix for `struct drm_gpusvm_pages` in `include/drm/drm_gpusvm.h`. The change is correct and well-motivated. The existing kernel-doc uses `@flags.*` dotted notation (e.g., `@flags.migrate_devmem`) to document sub-fields of the `flags` member, but that notation only works for **anonymous** embedded structs that kernel-doc flattens into the parent. Here, `flags` is of the named type `struct drm_gpusvm_pages_flags`, which already has its own kernel-doc block — so the dotted entries are redundant, don't match any flattened member, and generate "Excess struct member" warnings from `scripts/kernel-doc`.

The fix correctly drops the five `@flags.*` lines and replaces them with a single `@flags` entry using the `&struct drm_gpusvm_pages_flags` cross-reference. No functional change.

The commit message is clear and thorough, including the exact warnings being fixed and a link to the failing CI series. No concerns with the patch itself.

**Minor process note:** The patch lists `Assisted-by: GitHub Copilot` and Cc's `copilot@github.com`. While this is a trivial doc change, some subsystem maintainers have policies about AI-attribution tags — worth checking if drm-misc has any stance on this. The `Assisted-by:` tag is not an officially recognized kernel tag (unlike `Co-developed-by:` or `Suggested-by:`).

**Verdict:** Looks good. Trivial and correct fix.

---

---
Generated by Claude Code Patch Reviewer