public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages
Date: Tue, 05 May 2026 09:12:49 +1000	[thread overview]
Message-ID: <review-patch1-20260501174435.4053381-1-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260501174435.4053381-1-shuicheng.lin@intel.com>

Patch Review

**Correctness: Good.** The distinction between anonymous structs (where dotted notation is valid) and named struct types (where it isn't) is correctly identified. Compare with `struct drm_gpusvm_notifier` in the same file (line ~96 in the current tree), which uses `@flags.removed` — and that one is correct because `flags` there is an anonymous `struct { u32 removed : 1; }`, not a named type.

**The replacement line is well-formed:**
```
- * @flags: Flags for range
- * @flags.migrate_devmem: Flag indicating whether the range can be migrated to device memory
- * @flags.unmapped: Flag indicating if the range has been unmapped
- * @flags.partial_unmap: Flag indicating if the range has been partially unmapped
- * @flags.has_devmem_pages: Flag indicating if the range has devmem pages
- * @flags.has_dma_mapping: Flag indicating if the range has a DMA mapping
+ * @flags: Flags for the range; see &struct drm_gpusvm_pages_flags
```

The `&struct drm_gpusvm_pages_flags` syntax is standard kernel-doc cross-referencing and will produce a hyperlink in the generated documentation.

**One very minor nit:** The wording changed from "Flags for range" to "Flags for the range" (added "the"). Fine, slightly better English.

**No issues found.** 

Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-04 23:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 17:44 [PATCH v2] drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Shuicheng Lin
2026-05-04 23:12 ` Claude Code Review Bot [this message]
2026-05-04 23:12 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-01 17:59 [PATCH v3] " Shuicheng Lin
2026-05-04 23:11 ` Claude review: " Claude Code Review Bot
2026-05-04 23:11 ` Claude Code Review Bot
2026-05-01 17:13 [PATCH] " Shuicheng Lin
2026-05-04 23:13 ` Claude review: " Claude Code Review Bot
2026-05-04 23:13 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260501174435.4053381-1-shuicheng.lin@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox