From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: vop2: Fix layer cfg done timeout on multi-output setups
Date: Tue, 05 May 2026 08:08:45 +1000 [thread overview]
Message-ID: <review-overall-20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com> (raw)
In-Reply-To: <20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com>
Overall Series Review
Subject: drm/rockchip: vop2: Fix layer cfg done timeout on multi-output setups
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Patches: 6
Reviewed: 2026-05-05T08:08:45.269819
---
This is a well-structured 5-patch series fixing a real race condition in the VOP2 overlay layer configuration path on RK3568/RK3588 multi-output setups. The cover letter clearly explains the two root causes (patches 1 and 2) and separates the cleanups (patches 3-5).
The two bug fixes are correct: patch 1 fixes passing an already-clobbered value as the wait target, and patch 2 reorders operations so the previous VP's vsync can still latch the pending configuration before LAYERSEL_REGDONE_SEL is switched. The cleanup patches are straightforward and low-risk.
One concern worth raising is the interaction between patches 3 and 5 and the `readx_poll_timeout_atomic` spin in `rk3568_vop2_wait_for_layer_cfg_done()` — see patch 5 comments below.
**Recommendation: Patches 1 and 2 look good for merge (with Fixes tags for stable). Patches 3-5 are clean and correct but patch 5 has a minor concern worth discussing.**
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-04 22:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 18:23 [PATCH 0/5] drm/rockchip: vop2: Fix layer cfg done timeout on multi-output setups Cristian Ciocaltea
2026-05-04 18:23 ` [PATCH 1/5] drm/rockchip: vop2: Fix wrong wait target in layer cfg done check Cristian Ciocaltea
2026-05-04 22:08 ` Claude review: " Claude Code Review Bot
2026-05-04 18:24 ` [PATCH 2/5] drm/rockchip: vop2: Wait for layer cfg done before switching LAYERSEL_REGDONE_SEL Cristian Ciocaltea
2026-05-04 22:08 ` Claude review: " Claude Code Review Bot
2026-05-04 18:24 ` [PATCH 3/5] drm/rockchip: vop2: Delay old_{layer|port}_sel updates in setup_layer_mixer() Cristian Ciocaltea
2026-05-04 22:08 ` Claude review: " Claude Code Review Bot
2026-05-04 18:24 ` [PATCH 4/5] drm/rockchip: vop2: Drop redundant zero-init " Cristian Ciocaltea
2026-05-04 22:08 ` Claude review: " Claude Code Review Bot
2026-05-04 18:24 ` [PATCH 5/5] drm/rockchip: vop2: Use vop2->old_layer_sel directly in wait_for_layer_cfg_done() Cristian Ciocaltea
2026-05-04 22:08 ` Claude review: " Claude Code Review Bot
2026-05-04 22:08 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox