[PATCH] fastrpc: Reduce log level for DSP info and reserved memory messages

[PATCH] fastrpc: Reduce log level for DSP info and reserved memory messages

[Jianping Li]

On some platforms (e.g. QCS615 Talos), fastrpc may temporarily fail
to retrieve DSP attributes during boot, resulting in repeated
"Error: dsp information is incorrect" messages printed on the
console.

These messages are observed continuously during boot when metadata
flashing is enabled as part of RC releases, causing unnecessary
log noise.

Similarly, the absence of reserved DMA memory is a valid
configuration and does not represent an error condition.

Since these scenarios are expected and do not indicate a failure,
downgrade the log level from dev_err/dev_info to dev_dbg to avoid
flooding the console.

No functional change intended.

Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
---
 drivers/misc/fastrpc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 1080f9acf70a..05ec14c07fd0 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1802,7 +1802,7 @@ static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap,
 		kfree(dsp_attributes);
 		return -EOPNOTSUPP;
 	} else if (err) {
-		dev_err(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err);
+		dev_dbg(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err);
 		kfree(dsp_attributes);
 		return err;
 	}
@@ -2361,7 +2361,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
 	}
 
 	if (of_reserved_mem_device_init_by_idx(rdev, rdev->of_node, 0))
-		dev_info(rdev, "no reserved DMA memory for FASTRPC\n");
+		dev_dbg(rdev, "no reserved DMA memory for FASTRPC\n");
 
 	vmcount = of_property_read_variable_u32_array(rdev->of_node,
 				"qcom,vmids", &vmids[0], 0, FASTRPC_MAX_VMIDS);
-- 
2.43.0

Claude review: fastrpc: Reduce log level for DSP info and reserved memory messages

[Claude Code Review Bot]

Overall Series Review

Subject: fastrpc: Reduce log level for DSP info and reserved memory messages
Author: Jianping Li <jianping.li@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-05-16T11:18:47.374563

---

This is a single, straightforward patch that downgrades two log messages in the fastrpc driver from `dev_err`/`dev_info` to `dev_dbg`. The rationale is reasonable: both messages can fire repeatedly during boot on certain platforms and don't represent true error conditions. The patch is small, well-scoped, and the commit message clearly explains the motivation.

**Minor concerns exist with the first hunk** — the DSP information error path does return a non-zero error code to the ioctl caller, so silencing it completely to `dev_dbg` may make debugging harder for developers who don't have dynamic debug enabled. The second hunk (reserved memory) is clearly correct since absence of reserved DMA memory is explicitly described as a valid configuration.

No functional issues. No correctness problems.

---
Generated by Claude Code Patch Reviewer

Claude review: fastrpc: Reduce log level for DSP info and reserved memory messages

[Claude Code Review Bot]

Patch Review

**Hunk 1 (line ~1804): DSP information error → dev_dbg**

```c
} else if (err) {
    dev_dbg(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err);
```

This path is reached from `fastrpc_get_dsp_info()` (line 1836), which is an ioctl handler — so this is user-triggerable. That actually supports the downgrade: a `dev_err` on a user-triggerable path can be used to flood the kernel log. However, this is also a genuine error return path (the function returns `err` to the caller), not just a "try again later" situation.

- **Nit**: The message string still says `"Error: ..."` which is slightly odd for a `dev_dbg` message. If the intent is that this is an expected/transient condition, consider rewording to something like `"failed to get dsp info, err: %d\n"`. But this is cosmetic.

- **Potential concern**: The commit message says this happens "temporarily during boot" — if it only happens during boot and self-resolves, `dev_dbg` is fine. But if the DSP never comes up and this error persists, having it at `dev_dbg` means an operator will see no indication of the problem unless dynamic debug is enabled. A possible alternative would be `dev_info_ratelimited()` to reduce flood while keeping visibility, but the author knows their platform better than I do and `dev_dbg` is a defensible choice given the ioctl-triggerable nature.

**Hunk 2 (line ~2363): Reserved DMA memory → dev_dbg**

```c
if (of_reserved_mem_device_init_by_idx(rdev, rdev->of_node, 0))
    dev_dbg(rdev, "no reserved DMA memory for FASTRPC\n");
```

This is in the probe path (`fastrpc_rpmsg_probe`). The original `dev_info` is reasonable to downgrade — the commit message correctly notes that lack of reserved DMA memory is a valid configuration, not an error. The probe continues regardless of this result, so the message is purely informational. `dev_dbg` is appropriate here.

**Verdict**: The patch is correct and reasonable. The only suggestion is cosmetic (dropping the "Error:" prefix from the `dev_dbg` string in hunk 1). No objections to merging.

---
Generated by Claude Code Patch Reviewer