public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: set SB_I_NOEXEC on the pseudo filesystem
Date: Mon, 25 May 2026 21:11:46 +1000	[thread overview]
Message-ID: <review-overall-20260520214350.168689-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260520214350.168689-1-jhubbard@nvidia.com>

Overall Series Review

Subject: dma-buf: set SB_I_NOEXEC on the pseudo filesystem
Author: John Hubbard <jhubbard@nvidia.com>
Patches: 3
Reviewed: 2026-05-25T21:11:46.873174

---

This is a single-patch fix, not a series. The patch is **correct, well-motivated, and straightforward**. It fixes a real regression introduced by commit `1e7ab6f67824` ("anon_inode: rework assertions") in 6.17, where `path_noexec()` now warns (via `VFS_WARN_ON_ONCE`) when an `S_ANON_INODE` inode is encountered on a superblock that lacks `SB_I_NOEXEC`. The dma-buf pseudo filesystem uses `alloc_anon_inode()` (via `init_pseudo`) but never set `SB_I_NOEXEC`, triggering the warning on any dma-buf mmap.

The fix follows the established pattern used by every other pseudo filesystem in the kernel that issues anonymous inodes (`anon_inodes.c`, `aio.c`, `secretmem.c`, `guest_memfd.c`, `pidfs.c`, `nsfs.c`, etc.) — all set `fc->s_iflags |= SB_I_NOEXEC` in their `init_fs_context` callback.

The `Fixes:` tag and `Cc: stable` are appropriate since this is a regression fix for a new assertion.

No concerns with this patch.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 21:43 [PATCH] dma-buf: set SB_I_NOEXEC on the pseudo filesystem John Hubbard
2026-05-21 11:54 ` Christian Brauner
2026-05-21 22:54   ` John Hubbard
2026-05-25 11:11 ` Claude Code Review Bot [this message]
2026-05-25 11:11 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260520214350.168689-1-jhubbard@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox