From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: set SB_I_NOEXEC on the pseudo filesystem
Date: Mon, 25 May 2026 21:11:47 +1000 [thread overview]
Message-ID: <review-patch1-20260520214350.168689-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260520214350.168689-1-jhubbard@nvidia.com>
Patch Review
**Correctness: Good.** The one-line change is placed at the right location — inside `dma_buf_fs_init_context()`, after `init_pseudo()` succeeds and before returning. The field `fc->s_iflags` is defined in `struct fs_context` (at `include/linux/fs_context.h:106`) and is documented as being OR'd into `sb->s_iflags` during superblock creation, so this will propagate correctly.
```c
ctx->dops = &dma_buf_dentry_ops;
+ fc->s_iflags |= SB_I_NOEXEC;
return 0;
```
This exactly mirrors the pattern in `anon_inodefs_init_fs_context()` at `fs/anon_inodes.c:89`:
```c
fc->s_iflags |= SB_I_NOEXEC;
```
**Commit message: Good.** The commit message clearly explains:
- What the bug is (missing `SB_I_NOEXEC` on dmabuf superblock)
- What triggers it (the new `path_noexec()` assertion from 6.17)
- The exact warning stack trace
- A concrete reproducer using the dma_heap selftest
- Why the fix is correct (dma-bufs have no business being executable)
**Fixes tag: Correct.** Points to `1e7ab6f67824` which introduced the assertion that now fires. This is the right commit to cite since dma-buf was working before that assertion was added.
**Minor nit (non-blocking):** The placement of `fc->s_iflags |= SB_I_NOEXEC` after `ctx->dops = &dma_buf_dentry_ops` works but conventionally other filesystems tend to set the iflags before other context setup (as in `anon_inodes.c`). This is purely cosmetic and doesn't affect correctness at all.
**Verdict: Looks good.** Clean, minimal, correct fix. Ready to merge.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 21:43 [PATCH] dma-buf: set SB_I_NOEXEC on the pseudo filesystem John Hubbard
2026-05-21 11:54 ` Christian Brauner
2026-05-21 22:54 ` John Hubbard
2026-05-25 11:11 ` Claude review: " Claude Code Review Bot
2026-05-25 11:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260520214350.168689-1-jhubbard@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox