From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space
Date: Wed, 27 May 2026 14:54:39 +1000 [thread overview]
Message-ID: <review-overall-20260526-hot-plug-passup-v10-0-f62351a9ea3e@collabora.com> (raw)
In-Reply-To: <20260526-hot-plug-passup-v10-0-f62351a9ea3e@collabora.com>
Overall Series Review
Subject: Pass down hot-plug CONNECTOR ID to user-space
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 3
Reviewed: 2026-05-27T14:54:39.574822
---
This is a well-motivated 2-patch series (v10) that passes connector IDs in hotplug uevents to userspace. The real-world problem is clear: compositors like Weston receiving generic hotplug events can miss fast on-off-on transitions on a connector, leaving it dead until manually replugged. The design is sound — the sysfs uevent (`kobject_uevent_env`) is sent inside the `mode_config.mutex` while iterating connectors, and `drm_client_dev_hotplug()` (which calls into fb helpers that may re-acquire the mutex) is deferred until after the lock is released. This avoids the AB-BA deadlock that plagued earlier versions.
The series is at a good level of maturity after 10 revisions and has a Reviewed-by from Daniel Stone on patch 1. No correctness bugs found. A few minor observations follow.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 12:39 [PATCH v10 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-05-26 12:39 ` [PATCH v10 1/2] drm/connector: Fix epoch_counter docs to reflect reality Nicolas Frattaroli
2026-05-27 4:54 ` Claude review: " Claude Code Review Bot
2026-05-26 12:39 ` [PATCH v10 2/2] drm: Send per-connector hotplug events Nicolas Frattaroli
2026-05-27 4:54 ` Claude review: " Claude Code Review Bot
2026-05-27 4:54 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 18:24 [PATCH v9 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-04-22 21:22 ` Claude review: " Claude Code Review Bot
2026-04-22 12:35 [PATCH v8 0/2] " Nicolas Frattaroli
2026-04-22 21:36 ` Claude review: " Claude Code Review Bot
2026-02-17 19:00 [PATCH v7 0/2] " Nicolas Frattaroli
2026-02-17 20:43 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526-hot-plug-passup-v10-0-f62351a9ea3e@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox