Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge
Author: syyang@lontium.com
Patches: 3
Reviewed: 2026-06-04T16:51:15.381267

---

This is v13 of a 2-patch series adding support for the Lontium LT7911EXC eDP-to-MIPI-DSI bridge chip. The DT binding (patch 1) has already been reviewed and acked by Krzysztof Kozlowski. The driver (patch 2) has a Reviewed-by from Dmitry Baryshkov.

The driver's overall structure is reasonable: it uses `devm_drm_bridge_alloc`, implements a MIPI DSI host for downstream panel attachment, and provides firmware upgrade through a sysfs trigger. However, there are several issues remaining, ranging from a potentially dangerous direct manipulation of a DRM-core-managed field to coding style violations and error handling gaps.

**Key concerns:**
1. **`bridge->dev = NULL` in `.detach`** -- No other bridge driver does this. The DRM core manages this field; touching it from a driver is incorrect and risks framework-level breakage.
2. **Firmware upgrade error recovery leaves MCU halted** -- Error paths after `lt7911exc_hw_mcu_halt` do not restart the MCU or reset the chip, potentially leaving the hardware in a broken state.
3. **Missing locking on register accesses during firmware upgrade** -- The bulk of the erase/write/verify operations run without `ocm_lock`, relying solely on the `upgrade` flag, but a window exists during reset where state is inconsistent.
4. **Kernel coding style violations** -- C++ style `//` comments throughout.

---

---
Generated by Claude Code Patch Reviewer